[43/51] fs/hfsplus: Use the enum req_op and blk_opf_t types

Message ID	20220623180528.3595304-44-bvanassche@acm.org (mailing list archive)
State	New, archived
Headers	show Return-Path: <linux-block-owner@kernel.org> From: Bart Van Assche <bvanassche@acm.org> To: Jens Axboe <axboe@kernel.dk> Cc: linux-block@vger.kernel.org, Christoph Hellwig <hch@lst.de>, Bart Van Assche <bvanassche@acm.org> Subject: [PATCH 43/51] fs/hfsplus: Use the enum req_op and blk_opf_t types Date: Thu, 23 Jun 2022 11:05:20 -0700 Message-Id: <20220623180528.3595304-44-bvanassche@acm.org> In-Reply-To: <20220623180528.3595304-1-bvanassche@acm.org> References: <20220623180528.3595304-1-bvanassche@acm.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: bulk
Series	Improve static type checking for request flags \| expand [00/51] Improve static type checking for request flags [01/51] treewide: Rename enum req_opf into enum req_op [02/51] block: Use enum req_op where appropriate [03/51] block: Change the type of the last .rw_page() argument [04/51] block: Change the type of req_op() and bio_op() into enum req_op [05/51] block: Introduce the type blk_opf_t [06/51] block: Use the new blk_opf_t type [07/51] blktrace: Use the new blk_opf_t type [08/51] blktrace: Trace remap operations correctly [09/51] block/brd: Use the enum req_op type [10/51] block/drbd: Use the enum req_op and blk_opf_t types [11/51] block/floppy: Fix a sparse warning [12/51] block/null_blk: Fix sparse warnings in tracing code [13/51] um: Use enum req_op where appropriate [14/51] dm/core: Use the enum req_op and blk_opf_t types [15/51] dm/bufio: Change 'int rw' into 'enum req_op op' [16/51] dm/kcopyd: Rename kcopyd_job.rw into kcopyd_job.op [17/51] dm/ebs: Change 'int rw' into 'enum req_op op' [18/51] dm/dm-flakey: Use the new blk_opf_t type [19/51] dm/dm-integrity: Use the enum req_op and blk_opf_t types [20/51] dm/dm-snap: Use the enum req_op and blk_opf_t types [21/51] dm/dm-zoned: Use the enum req_op type [22/51] md/core: Use the enum req_op and blk_opf_t types [23/51] md/bcache: Use the enum req_op and blk_opf_t types [24/51] md/raid1: Use the new blk_opf_t type [25/51] md/raid10: Use the new blk_opf_t type [26/51] md/raid5: Use the enum req_op and blk_opf_t types [27/51] nvme/host: Use the enum req_op and blk_opf_t types [28/51] nvme/target: Use the new blk_opf_t type [29/51] scsi/core: Improve static type checking [30/51] scsi/core: Change the return type of scsi_noretry_cmd() into bool [31/51] scsi/core: Use the new blk_opf_t type [32/51] scsi/device_handlers: Use the new blk_opf_t type [33/51] scsi/ufs: Rename a 'dir' argument into 'op' [34/51] scsi/target: Use the new blk_opf_t type [35/51] mm: Use the new blk_opf_t type [36/51] fs/buffer: Use the new blk_opf_t type [37/51] fs/direct-io: Use the enum req_op and blk_opf_t types [38/51] fs/mpage: Use the new blk_opf_t type [39/51] fs/btrfs: Use the enum req_op and blk_opf_t types [40/51] fs/ext4: Use the new blk_opf_t type [41/51] fs/f2fs: Use the enum req_op and blk_opf_t types [42/51] fs/gfs2: Use the enum req_op and blk_opf_t types [43/51] fs/hfsplus: Use the enum req_op and blk_opf_t types [44/51] fs/iomap: Use the new blk_opf_t type [45/51] fs/jbd2: Fix the documentation of the jbd2_write_superblock() callers [46/51] fs/nilfs: Use the enum req_op and blk_opf_t types [47/51] fs/ntfs3: Use enum req_op where appropriate [48/51] fs/ocfs2: Use the enum req_op and blk_opf_t types [49/51] PM: Use the enum req_op and blk_opf_t types [50/51] fs/xfs: Use the enum req_op and blk_opf_t types [51/51] fs/zonefs: Fix sparse warnings in tracing code

Message ID

20220623180528.3595304-44-bvanassche@acm.org (mailing list archive)

State

New, archived

Headers

From: Bart Van Assche <bvanassche@acm.org>
To: Jens Axboe <axboe@kernel.dk>
Cc: linux-block@vger.kernel.org, Christoph Hellwig <hch@lst.de>,
        Bart Van Assche <bvanassche@acm.org>
Subject: [PATCH 43/51] fs/hfsplus: Use the enum req_op and blk_opf_t types
Date: Thu, 23 Jun 2022 11:05:20 -0700
Message-Id: <20220623180528.3595304-44-bvanassche@acm.org>
In-Reply-To: <20220623180528.3595304-1-bvanassche@acm.org>
References: <20220623180528.3595304-1-bvanassche@acm.org>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Precedence: bulk

Series

Improve static type checking for request flags | expand

Commit Message

Bart Van Assche June 23, 2022, 6:05 p.m. UTC

Improve static type checking by using the enum req_op type for variables
that represent a request operation and the new blk_opf_t type for
variables that represent request flags.

Cc: Christoph Hellwig <hch@lst.de>
Signed-off-by: Bart Van Assche <bvanassche@acm.org>
---
 fs/hfsplus/hfsplus_fs.h | 2 +-
 fs/hfsplus/wrapper.c    | 5 +++--
 2 files changed, 4 insertions(+), 3 deletions(-)

diff --git a/fs/hfsplus/hfsplus_fs.h b/fs/hfsplus/hfsplus_fs.h
index 396e73aa0961..ac93c2445b29 100644
--- a/fs/hfsplus/hfsplus_fs.h
+++ b/fs/hfsplus/hfsplus_fs.h
@@ -525,7 +525,7 @@  int hfsplus_compare_dentry(const struct dentry *dentry, unsigned int len,
 
 /* wrapper.c */
 int hfsplus_submit_bio(struct super_block *sb, sector_t sector, void *buf,
-		       void **data, int op, int op_flags);
+		       void **data, enum req_op op, blk_opf_t op_flags);
 int hfsplus_read_wrapper(struct super_block *sb);
 
 /*
diff --git a/fs/hfsplus/wrapper.c b/fs/hfsplus/wrapper.c
index 0b8ad6586df5..bf5e89748df0 100644
--- a/fs/hfsplus/wrapper.c
+++ b/fs/hfsplus/wrapper.c
@@ -45,7 +45,8 @@  struct hfsplus_wd {
  * will work correctly.
  */
 int hfsplus_submit_bio(struct super_block *sb, sector_t sector,
-		       void *buf, void **data, int op, int op_flags)
+		       void *buf, void **data, enum req_op op,
+		       blk_opf_t op_flags)
 {
 	struct bio *bio;
 	int ret = 0;
@@ -66,7 +67,7 @@  int hfsplus_submit_bio(struct super_block *sb, sector_t sector,
 	bio = bio_alloc(sb->s_bdev, 1, op | op_flags, GFP_NOIO);
 	bio->bi_iter.bi_sector = sector;
 
-	if (op != WRITE && data)
+	if (op != REQ_OP_WRITE && data)
 		*data = (u8 *)buf + offset;
 
 	while (io_size > 0) {

[43/51] fs/hfsplus: Use the enum req_op and blk_opf_t types

Commit Message

Patch