diff mbox series

[v3,63/63] fs/zonefs: Use the enum req_op type for tracing request operations

Message ID 20220714180729.1065367-64-bvanassche@acm.org (mailing list archive)
State New, archived
Headers show
Series Improve static type checking for request flags | expand

Commit Message

Bart Van Assche July 14, 2022, 6:07 p.m. UTC 
Improve static type checking by using the enum req_op type for request
operations.

Reviewed-by: Johannes Thumshirn <jth@kernel.org>
Reviewed-by: Damien Le Moal <damien.lemoal@opensource.wdc.com>
Cc: Naohiro Aota <naohiro.aota@wdc.com>
Signed-off-by: Bart Van Assche <bvanassche@acm.org>
---
 fs/zonefs/trace.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Damien Le Moal July 18, 2022, 10:49 a.m. UTC | #1 
On 7/15/22 03:07, Bart Van Assche wrote:
> Improve static type checking by using the enum req_op type for request
> operations.
> 
> Reviewed-by: Johannes Thumshirn <jth@kernel.org>
> Reviewed-by: Damien Le Moal <damien.lemoal@opensource.wdc.com>

Bart,

Please change this tag to "Acked-by". Thanks.

> Cc: Naohiro Aota <naohiro.aota@wdc.com>
> Signed-off-by: Bart Van Assche <bvanassche@acm.org>
> ---
>  fs/zonefs/trace.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/fs/zonefs/trace.h b/fs/zonefs/trace.h
> index 21501da764bd..42edcfd393ed 100644
> --- a/fs/zonefs/trace.h
> +++ b/fs/zonefs/trace.h
> @@ -25,7 +25,7 @@ TRACE_EVENT(zonefs_zone_mgmt,
>  	    TP_STRUCT__entry(
>  			     __field(dev_t, dev)
>  			     __field(ino_t, ino)
> -			     __field(int, op)
> +			     __field(enum req_op, op)
>  			     __field(sector_t, sector)
>  			     __field(sector_t, nr_sectors)
>  	    ),
diff mbox series

Patch

diff --git a/fs/zonefs/trace.h b/fs/zonefs/trace.h
index 21501da764bd..42edcfd393ed 100644
--- a/fs/zonefs/trace.h
+++ b/fs/zonefs/trace.h
@@ -25,7 +25,7 @@  TRACE_EVENT(zonefs_zone_mgmt,
 	    TP_STRUCT__entry(
 			     __field(dev_t, dev)
 			     __field(ino_t, ino)
-			     __field(int, op)
+			     __field(enum req_op, op)
 			     __field(sector_t, sector)
 			     __field(sector_t, nr_sectors)
 	    ),