diff mbox series

[blktests,v3,6/6] srp/rc: allow test with built-in sd_mod and sg drivers

Message ID 20220819093920.84992-7-shinichiro.kawasaki@wdc.com (mailing list archive)
State New, archived
Headers show
Series fix module check issues | expand

Commit Message

Shin'ichiro Kawasaki Aug. 19, 2022, 9:39 a.m. UTC
The srp test group can be executed with built-in sd_mod and sg drivers.
Check the drivers with _have_drivers() in place of _have_modules.

Signed-off-by: Shin'ichiro Kawasaki <shinichiro.kawasaki@wdc.com>
---
 tests/srp/rc | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

Comments

Bart Van Assche Aug. 19, 2022, 2:54 p.m. UTC | #1
On 8/19/22 02:39, Shin'ichiro Kawasaki wrote:
> The srp test group can be executed with built-in sd_mod and sg drivers.
> Check the drivers with _have_drivers() in place of _have_modules.

Reviewed-by: Bart Van Assche <bvanassche@acm.org>
diff mbox series

Patch

diff --git a/tests/srp/rc b/tests/srp/rc
index 94ee97c..a3a96a7 100755
--- a/tests/srp/rc
+++ b/tests/srp/rc
@@ -35,6 +35,7 @@  group_requires() {
 		SKIP_REASONS+=("LIO must be unloaded before the SRP tests are run")
 		return
 	fi
+	_have_drivers sd_mod sg
 	required_modules=(
 		dm_multipath
 		dm_queue_length
@@ -51,9 +52,6 @@  group_requires() {
 		scsi_dh_alua
 		scsi_dh_emc
 		scsi_dh_rdac
-		sd_mod
-		sd_mod
-		sg
 		target_core_iblock
 		target_core_mod
 	)