diff mbox series

[2/8] blk-iocost: Reset vtime_base_rate in ioc_refresh_params

Message ID 20221017020011.25016-3-shikemeng@huawei.com (mailing list archive)
State New, archived
Headers show
Series A few cleanup and bugfix patches for blk-iocost | expand

Commit Message

Kemeng Shi Oct. 17, 2022, 2 a.m. UTC 
Since commit ac33e91e2daca("blk-iocost: implement vtime loss compensation")
split vtime_rate into vtime_rate and vtime_base_rate, we need reset both
vtime_base_rate and vtime_rate when device parameters are refreshed.
If vtime_base_rate is no reset here, vtime_rate will be overwritten with
old vtime_base_rate soon in ioc_refresh_vrate.

Signed-off-by: Kemeng Shi <shikemeng@huawei.com>
---
 block/blk-iocost.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

Comments

Tejun Heo Oct. 17, 2022, 6:59 p.m. UTC | #1 
On Mon, Oct 17, 2022 at 10:00:05AM +0800, Kemeng Shi wrote:
> Since commit ac33e91e2daca("blk-iocost: implement vtime loss compensation")
> split vtime_rate into vtime_rate and vtime_base_rate, we need reset both
> vtime_base_rate and vtime_rate when device parameters are refreshed.
> If vtime_base_rate is no reset here, vtime_rate will be overwritten with
> old vtime_base_rate soon in ioc_refresh_vrate.
> 
> Signed-off-by: Kemeng Shi <shikemeng@huawei.com>

Acked-by: Tejun Heo <tj@kernel.org>

Thanks.
diff mbox series

Patch

diff --git a/block/blk-iocost.c b/block/blk-iocost.c
index be4bc38821e2..9214733bbc14 100644
--- a/block/blk-iocost.c
+++ b/block/blk-iocost.c
@@ -906,8 +906,10 @@  static bool ioc_refresh_params(struct ioc *ioc, bool force)
 	if (idx == ioc->autop_idx && !force)
 		return false;
 
-	if (idx != ioc->autop_idx)
+	if (idx != ioc->autop_idx) {
 		atomic64_set(&ioc->vtime_rate, VTIME_PER_USEC);
+		ioc->vtime_base_rate = VTIME_PER_USEC;
+	}
 
 	ioc->autop_idx = idx;
 	ioc->autop_too_fast_at = 0;