diff mbox series

[2/4] ublk_drv: comment on ublk_driver entry of Kconfig

Message ID 20221029010432.598367-3-ming.lei@redhat.com (mailing list archive)
State New, archived
Headers show
Series ublk_drv: uring_cmd queueing improvement and cleanup | expand

Commit Message

Ming Lei Oct. 29, 2022, 1:04 a.m. UTC 
Add help info for choosing to build ublk_drv as module or builtin.

Signed-off-by: Ming Lei <ming.lei@redhat.com>
---
 drivers/block/Kconfig | 6 ++++++
 1 file changed, 6 insertions(+)

Comments

Ziyang Zhang Oct. 31, 2022, 3:16 a.m. UTC | #1 
On 2022/10/29 09:04, Ming Lei wrote:
> Add help info for choosing to build ublk_drv as module or builtin.
> 
> Signed-off-by: Ming Lei <ming.lei@redhat.com>
> ---
>  drivers/block/Kconfig | 6 ++++++
>  1 file changed, 6 insertions(+)
> 
> diff --git a/drivers/block/Kconfig b/drivers/block/Kconfig
> index db1b4b202646..a41145d52de9 100644
> --- a/drivers/block/Kconfig
> +++ b/drivers/block/Kconfig
> @@ -408,6 +408,12 @@ config BLK_DEV_UBLK
>  	  definition isn't finalized yet, and might change according to future
>  	  requirement, so mark is as experimental now.
>  
> +	  Say Y if you want to get better performance because task_work_add()
> +	  can be used in IO path for replacing io_uring cmd, which will become
> +	  shared between IO tasks and ubq daemon, meantime task_work_add() can
> +	  can handle batch more effectively, but task_work_add() isn't exported
> +	  for module, so ublk has to be built to kernel.
> +
>  source "drivers/block/rnbd/Kconfig"
>  
>  endif # BLK_DEV

Reviewed-by: ZiyangZhang <ZiyangZhang@linux.alibaba.com>
diff mbox series

Patch

diff --git a/drivers/block/Kconfig b/drivers/block/Kconfig
index db1b4b202646..a41145d52de9 100644
--- a/drivers/block/Kconfig
+++ b/drivers/block/Kconfig
@@ -408,6 +408,12 @@  config BLK_DEV_UBLK
 	  definition isn't finalized yet, and might change according to future
 	  requirement, so mark is as experimental now.
 
+	  Say Y if you want to get better performance because task_work_add()
+	  can be used in IO path for replacing io_uring cmd, which will become
+	  shared between IO tasks and ubq daemon, meantime task_work_add() can
+	  can handle batch more effectively, but task_work_add() isn't exported
+	  for module, so ublk has to be built to kernel.
+
 source "drivers/block/rnbd/Kconfig"
 
 endif # BLK_DEV