From patchwork Tue Nov 1 09:34:06 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Kemeng Shi X-Patchwork-Id: 13026772 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 78C58FA373D for ; Tue, 1 Nov 2022 09:34:41 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230199AbiKAJei (ORCPT ); Tue, 1 Nov 2022 05:34:38 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40068 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230169AbiKAJe2 (ORCPT ); Tue, 1 Nov 2022 05:34:28 -0400 Received: from szxga01-in.huawei.com (szxga01-in.huawei.com [45.249.212.187]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3797218E35; Tue, 1 Nov 2022 02:34:27 -0700 (PDT) Received: from kwepemi500016.china.huawei.com (unknown [172.30.72.54]) by szxga01-in.huawei.com (SkyGuard) with ESMTP id 4N1lBP3k1czpW4d; Tue, 1 Nov 2022 17:30:53 +0800 (CST) Received: from huawei.com (10.174.178.129) by kwepemi500016.china.huawei.com (7.221.188.220) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Tue, 1 Nov 2022 17:34:25 +0800 From: Kemeng Shi To: , CC: , , Subject: [PATCH 09/20] block, bfq: remove redundant check if (bfqq->dispatched > 0) Date: Tue, 1 Nov 2022 17:34:06 +0800 Message-ID: <20221101093417.10540-10-shikemeng@huawei.com> X-Mailer: git-send-email 2.14.1.windows.1 In-Reply-To: <20221101093417.10540-1-shikemeng@huawei.com> References: <20221101093417.10540-1-shikemeng@huawei.com> MIME-Version: 1.0 X-Originating-IP: [10.174.178.129] X-ClientProxiedBy: dggems703-chm.china.huawei.com (10.3.19.180) To kwepemi500016.china.huawei.com (7.221.188.220) X-CFilter-Loop: Reflected Precedence: bulk List-ID: X-Mailing-List: linux-block@vger.kernel.org Commit 3c337690d2ebb7 ("block, bfq: avoid spurious switches to soft_rt of interactive queues") remove bfqq->wr_coeff != bfqd->bfq_wr_coeff check along with bfqq->dispatched == 0 to update soft_rt_next_start for interactive bfq_queues. So we can remove redundant bfqq->dispatched > 0 in else branch with current bfqq->dispatched == 0 check. Signed-off-by: Kemeng Shi --- block/bfq-iosched.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/block/bfq-iosched.c b/block/bfq-iosched.c index fa96cbca7814..8f6d05258f22 100644 --- a/block/bfq-iosched.c +++ b/block/bfq-iosched.c @@ -4375,7 +4375,7 @@ void bfq_bfqq_expire(struct bfq_data *bfqd, if (bfqq->dispatched == 0) bfqq->soft_rt_next_start = bfq_bfqq_softrt_next_start(bfqd, bfqq); - else if (bfqq->dispatched > 0) { + else { /* * Schedule an update of soft_rt_next_start to when * the task may be discovered to be isochronous.