diff mbox series

block: remove blkdev_writepages

Message ID 20221116132035.2192924-1-hch@lst.de (mailing list archive)
State New, archived
Headers show
Series block: remove blkdev_writepages | expand

Commit Message

Christoph Hellwig Nov. 16, 2022, 1:20 p.m. UTC
While the block device code should switch to implementing
->writepages instead of ->writepage eventually, the current
implementation is entirely pointless as it does the same looping over
->writepage as the generic code if no ->writepages is present.

Remove blkdev_writepages so that we can eventually unexport
generic_writepages.

Signed-off-by: Christoph Hellwig <hch@lst.de>
---
 block/fops.c | 7 -------
 1 file changed, 7 deletions(-)

Comments

Jens Axboe Nov. 16, 2022, 6:49 p.m. UTC | #1
On Wed, 16 Nov 2022 14:20:35 +0100, Christoph Hellwig wrote:
> While the block device code should switch to implementing
> ->writepages instead of ->writepage eventually, the current
> implementation is entirely pointless as it does the same looping over
> ->writepage as the generic code if no ->writepages is present.
> 
> Remove blkdev_writepages so that we can eventually unexport
> generic_writepages.
> 
> [...]

Applied, thanks!

[1/1] block: remove blkdev_writepages
      commit: 470373e888f494a52f9916bf3eeea41fe819d031

Best regards,
diff mbox series

Patch

diff --git a/block/fops.c b/block/fops.c
index b90742595317e..50d245e8c913a 100644
--- a/block/fops.c
+++ b/block/fops.c
@@ -405,12 +405,6 @@  static int blkdev_write_end(struct file *file, struct address_space *mapping,
 	return ret;
 }
 
-static int blkdev_writepages(struct address_space *mapping,
-			     struct writeback_control *wbc)
-{
-	return generic_writepages(mapping, wbc);
-}
-
 const struct address_space_operations def_blk_aops = {
 	.dirty_folio	= block_dirty_folio,
 	.invalidate_folio = block_invalidate_folio,
@@ -419,7 +413,6 @@  const struct address_space_operations def_blk_aops = {
 	.writepage	= blkdev_writepage,
 	.write_begin	= blkdev_write_begin,
 	.write_end	= blkdev_write_end,
-	.writepages	= blkdev_writepages,
 	.direct_IO	= blkdev_direct_IO,
 	.migrate_folio	= buffer_migrate_folio_norefs,
 	.is_dirty_writeback = buffer_check_dirty_writeback,