| Message ID | 20221116223945.1043785-1-alan.adamson@oracle.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | [v2] tests/nvme/039: Remove passthrough command tests | expand |
On 11/16/22 14:39, Alan Adamson wrote: > Commit d7ac8dca938c ("nvme: quiet user passthrough command errors") > disabled error logging for passthrough commands so the associated > tests should be removed. > > When an error logging opt-in mechanism for passthrough commands is > provided, the tests can be added back. > > Signed-off-by: Alan Adamson <alan.adamson@oracle.com> > --- Thanks for doing this, looks good. Reviewed-by: Chaitanya Kulkarni <kch@nvidia.com> -ck
On Nov 16, 2022 / 14:39, Alan Adamson wrote: > Commit d7ac8dca938c ("nvme: quiet user passthrough command errors") > disabled error logging for passthrough commands so the associated > tests should be removed. > > When an error logging opt-in mechanism for passthrough commands is > provided, the tests can be added back. > > Signed-off-by: Alan Adamson <alan.adamson@oracle.com> Thanks, applied. I confirmed it does not fail with kernel v6.0. Good :)
diff --git a/tests/nvme/039 b/tests/nvme/039 index e175055ddb06..11d6d24b6025 100755 --- a/tests/nvme/039 +++ b/tests/nvme/039 @@ -143,9 +143,6 @@ test_device() { inject_invalid_status_on_read "${ns_dev}" inject_write_fault_on_write "${ns_dev}" - inject_access_denied_on_identify "${ctrl_dev}" - inject_invalid_admin_cmd "${ctrl_dev}" - _nvme_err_inject_cleanup "${ns_dev}" "${ctrl_dev}" echo "Test complete" diff --git a/tests/nvme/039.out b/tests/nvme/039.out index 162935eb1d7b..139070d22240 100644 --- a/tests/nvme/039.out +++ b/tests/nvme/039.out @@ -2,6 +2,4 @@ Running nvme/039 Read(0x2) @ LBA 0, 1 blocks, Unrecovered Read Error (sct 0x2 / sc 0x81) DNR Read(0x2) @ LBA 0, 1 blocks, Unknown (sct 0x3 / sc 0x75) DNR Write(0x1) @ LBA 0, 1 blocks, Write Fault (sct 0x2 / sc 0x80) DNR - Identify(0x6), Access Denied (sct 0x2 / sc 0x86) DNR - Unknown(0x96), Invalid Command Opcode (sct 0x0 / sc 0x1) DNR Test complete
Commit d7ac8dca938c ("nvme: quiet user passthrough command errors") disabled error logging for passthrough commands so the associated tests should be removed. When an error logging opt-in mechanism for passthrough commands is provided, the tests can be added back. Signed-off-by: Alan Adamson <alan.adamson@oracle.com> --- tests/nvme/039 | 3 --- tests/nvme/039.out | 2 -- 2 files changed, 5 deletions(-)