| Message ID | 20221123060401.20392-8-shikemeng@huawei.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | A few bugfix and cleanup patches for blk-throttle | expand |
On Wed, Nov 23, 2022 at 02:03:57PM +0800, Kemeng Shi wrote: > Function tg_last_low_overflow_time is called with intermediate node as > following: > throtl_hierarchy_can_downgrade > throtl_tg_can_downgrade > tg_last_low_overflow_time > > throtl_hierarchy_can_upgrade > throtl_tg_can_upgrade > tg_last_low_overflow_time > > throtl_hierarchy_can_downgrade/throtl_hierarchy_can_upgrade will traverse > from leaf node to sub-root node and pass traversed intermediate node > to tg_last_low_overflow_time. > > No such limit could be found from context and implementation of > tg_last_low_overflow_time, so remove this limit in comment. > > Signed-off-by: Kemeng Shi <shikemeng@huawei.com> Acked-by: Tejun Heo <tj@kernel.org>
diff --git a/block/blk-throttle.c b/block/blk-throttle.c index 0aa21832cb96..bd07f562c799 100644 --- a/block/blk-throttle.c +++ b/block/blk-throttle.c @@ -1746,7 +1746,6 @@ static unsigned long __tg_last_low_overflow_time(struct throtl_grp *tg) return min(rtime, wtime); } -/* tg should not be an intermediate node */ static unsigned long tg_last_low_overflow_time(struct throtl_grp *tg) { struct throtl_service_queue *parent_sq;
Function tg_last_low_overflow_time is called with intermediate node as following: throtl_hierarchy_can_downgrade throtl_tg_can_downgrade tg_last_low_overflow_time throtl_hierarchy_can_upgrade throtl_tg_can_upgrade tg_last_low_overflow_time throtl_hierarchy_can_downgrade/throtl_hierarchy_can_upgrade will traverse from leaf node to sub-root node and pass traversed intermediate node to tg_last_low_overflow_time. No such limit could be found from context and implementation of tg_last_low_overflow_time, so remove this limit in comment. Signed-off-by: Kemeng Shi <shikemeng@huawei.com> --- block/blk-throttle.c | 1 - 1 file changed, 1 deletion(-)