| Message ID | 20221222191641.1643117-6-shikemeng@huaweicloud.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | A few bugfix and cleancode patch for bfq | expand |
On Fri 23-12-22 03:16:36, Kemeng Shi wrote: > The async_bfqq is assigned with bfqq->bic->bfqq[0], use it directly. > > Signed-off-by: Kemeng Shi <shikemeng@huaweicloud.com> Yeah, that is a more logical choice. Feel free to add: Reviewed-by: Jan Kara <jack@suse.cz> Honza > --- > block/bfq-iosched.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/block/bfq-iosched.c b/block/bfq-iosched.c > index c3c4c83ee95f..ebcafe3c4c3b 100644 > --- a/block/bfq-iosched.c > +++ b/block/bfq-iosched.c > @@ -4835,7 +4835,7 @@ static struct bfq_queue *bfq_select_queue(struct bfq_data *bfqd) > icq_to_bic(async_bfqq->next_rq->elv.icq) == bfqq->bic && > bfq_serv_to_charge(async_bfqq->next_rq, async_bfqq) <= > bfq_bfqq_budget_left(async_bfqq)) > - bfqq = bfqq->bic->bfqq[0]; > + bfqq = async_bfqq; > else if (bfqq->waker_bfqq && > bfq_bfqq_busy(bfqq->waker_bfqq) && > bfqq->waker_bfqq->next_rq && > -- > 2.30.0 >
diff --git a/block/bfq-iosched.c b/block/bfq-iosched.c index c3c4c83ee95f..ebcafe3c4c3b 100644 --- a/block/bfq-iosched.c +++ b/block/bfq-iosched.c @@ -4835,7 +4835,7 @@ static struct bfq_queue *bfq_select_queue(struct bfq_data *bfqd) icq_to_bic(async_bfqq->next_rq->elv.icq) == bfqq->bic && bfq_serv_to_charge(async_bfqq->next_rq, async_bfqq) <= bfq_bfqq_budget_left(async_bfqq)) - bfqq = bfqq->bic->bfqq[0]; + bfqq = async_bfqq; else if (bfqq->waker_bfqq && bfq_bfqq_busy(bfqq->waker_bfqq) && bfqq->waker_bfqq->next_rq &&
The async_bfqq is assigned with bfqq->bic->bfqq[0], use it directly. Signed-off-by: Kemeng Shi <shikemeng@huaweicloud.com> --- block/bfq-iosched.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)