| Message ID | 20221222191641.1643117-8-shikemeng@huaweicloud.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | A few bugfix and cleancode patch for bfq | expand |
On Fri 23-12-22 03:16:38, Kemeng Shi wrote: > We have already avoided a circular list in bfq_setup_merge (see comments > in bfq_setup_merge() for details), so bfq_queue will not appear in it's > new_bfqq list. Just remove this check. > > Signed-off-by: Kemeng Shi <shikemeng@huaweicloud.com> Looks good to me. Feel free to add: Reviewed-by: Jan Kara <jack@suse.cz> Honza > --- > block/bfq-iosched.c | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/block/bfq-iosched.c b/block/bfq-iosched.c > index 7c91d16dbf6f..89995815dbae 100644 > --- a/block/bfq-iosched.c > +++ b/block/bfq-iosched.c > @@ -5273,8 +5273,6 @@ void bfq_put_cooperator(struct bfq_queue *bfqq) > */ > __bfqq = bfqq->new_bfqq; > while (__bfqq) { > - if (__bfqq == bfqq) > - break; > next = __bfqq->new_bfqq; > bfq_put_queue(__bfqq); > __bfqq = next; > -- > 2.30.0 >
diff --git a/block/bfq-iosched.c b/block/bfq-iosched.c index 7c91d16dbf6f..89995815dbae 100644 --- a/block/bfq-iosched.c +++ b/block/bfq-iosched.c @@ -5273,8 +5273,6 @@ void bfq_put_cooperator(struct bfq_queue *bfqq) */ __bfqq = bfqq->new_bfqq; while (__bfqq) { - if (__bfqq == bfqq) - break; next = __bfqq->new_bfqq; bfq_put_queue(__bfqq); __bfqq = next;
We have already avoided a circular list in bfq_setup_merge (see comments in bfq_setup_merge() for details), so bfq_queue will not appear in it's new_bfqq list. Just remove this check. Signed-off-by: Kemeng Shi <shikemeng@huaweicloud.com> --- block/bfq-iosched.c | 2 -- 1 file changed, 2 deletions(-)