| Message ID | 20230416200930.29542-7-hch@lst.de (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | [1/7] blk-mq: factor out a blk_rq_init_flush helper | expand |
On 4/17/23 05:09, Christoph Hellwig wrote: > blk_flush_complete_seq currently queues requests that write data after > a pre-flush from the flush state machine at the head of the queue. > This doesn't really make sense, as the original request bypassed all > queue lists by directly diverting to blk_insert_flush from > blk_mq_submit_bio. > > Signed-off-by: Christoph Hellwig <hch@lst.de> Looks good to me. Reviewed-by: Damien Le Moal <dlemoal@kernel.org>
On 4/16/23 13:09, Christoph Hellwig wrote: > blk_flush_complete_seq currently queues requests that write data after > a pre-flush from the flush state machine at the head of the queue. > This doesn't really make sense, as the original request bypassed all > queue lists by directly diverting to blk_insert_flush from > blk_mq_submit_bio. insertations -> insertions Otherwise: Reviewed-by: Bart Van Assche <bvanassche@acm.org>
diff --git a/block/blk-flush.c b/block/blk-flush.c index 9eda6d46438dba..69e9806f575455 100644 --- a/block/blk-flush.c +++ b/block/blk-flush.c @@ -188,7 +188,7 @@ static void blk_flush_complete_seq(struct request *rq, case REQ_FSEQ_DATA: list_move_tail(&rq->flush.list, &fq->flush_data_in_flight); - blk_mq_add_to_requeue_list(rq, BLK_MQ_INSERT_AT_HEAD); + blk_mq_add_to_requeue_list(rq, 0); blk_mq_kick_requeue_list(q); break;
blk_flush_complete_seq currently queues requests that write data after a pre-flush from the flush state machine at the head of the queue. This doesn't really make sense, as the original request bypassed all queue lists by directly diverting to blk_insert_flush from blk_mq_submit_bio. Signed-off-by: Christoph Hellwig <hch@lst.de> --- block/blk-flush.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)