| Message ID | 20230420091104.1092972-1-ming.lei@redhat.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | ublk: don't return 0 in case of any failure | expand |
On Thu, 20 Apr 2023 17:11:04 +0800, Ming Lei wrote: > Commit 2d786e66c966 ("block: ublk: switch to ioctl command encoding") > starts to reset local variable of 'ret' as zero, then if any failure > happens when handling the three IO commands, 0 can be returned to ublk > server. > > Fix it by returning -EINVAL in case of command handling failure. > > [...] Applied, thanks! [1/1] ublk: don't return 0 in case of any failure (no commit info) Best regards,
diff --git a/drivers/block/ublk_drv.c b/drivers/block/ublk_drv.c index 5a03b765a6c1..cddfb33a5c3b 100644 --- a/drivers/block/ublk_drv.c +++ b/drivers/block/ublk_drv.c @@ -1315,6 +1315,7 @@ static int ublk_ch_uring_cmd(struct io_uring_cmd *cmd, unsigned int issue_flags) if (ret) goto out; + ret = -EINVAL; switch (_IOC_NR(cmd_op)) { case UBLK_IO_FETCH_REQ: /* UBLK_IO_FETCH_REQ is only allowed before queue is setup */
Commit 2d786e66c966 ("block: ublk: switch to ioctl command encoding") starts to reset local variable of 'ret' as zero, then if any failure happens when handling the three IO commands, 0 can be returned to ublk server. Fix it by returning -EINVAL in case of command handling failure. Cc: Christoph Hellwig <hch@lst.de> Fixes: 2d786e66c966 ("block: ublk: switch to ioctl command encoding") Signed-off-by: Ming Lei <ming.lei@redhat.com> --- drivers/block/ublk_drv.c | 1 + 1 file changed, 1 insertion(+)