| Message ID | 20230425034154.110099-1-ming.lei@redhat.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | block: sync part's ->bd_has_submit_bio with disk's | expand |
On Tue, 25 Apr 2023 11:41:54 +0800, Ming Lei wrote: > submit_bio() always uses bio->bi_bdev->bd_has_submit_bio to decide if > disk's ->submit_bio() is called, and bio->bi_bdev could point to one > partition device. > > So we have to sync part bdev's ->bd_has_submit_bio with disk's. > > > [...] Applied, thanks! [1/1] block: sync part's ->bd_has_submit_bio with disk's (no commit info) Best regards,
diff --git a/block/bdev.c b/block/bdev.c index 850852fe4b78..f1aee35ca266 100644 --- a/block/bdev.c +++ b/block/bdev.c @@ -418,8 +418,11 @@ struct block_device *bdev_alloc(struct gendisk *disk, u8 partno) bdev->bd_partno = partno; bdev->bd_inode = inode; bdev->bd_queue = disk->queue; + if (partno) + bdev->bd_has_submit_bio = disk->part0->bd_has_submit_bio; + else + bdev->bd_has_submit_bio = false; bdev->bd_stats = alloc_percpu(struct disk_stats); - bdev->bd_has_submit_bio = false; if (!bdev->bd_stats) { iput(inode); return NULL;
submit_bio() always uses bio->bi_bdev->bd_has_submit_bio to decide if disk's ->submit_bio() is called, and bio->bi_bdev could point to one partition device. So we have to sync part bdev's ->bd_has_submit_bio with disk's. Reported-by: Changhui Zhong <czhong@redhat.com> Link: https://lore.kernel.org/linux-block/ZEdItaPqif8fp85H@ovpn-8-24.pek2.redhat.com/T/#t Fixes: 9f4107b07b17 ("block: store bdev->bd_disk->fops->submit_bio state in bdev") Signed-off-by: Ming Lei <ming.lei@redhat.com> --- block/bdev.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-)