diff mbox series

[blktests,v3,06/12] Documentation: Add info on nvme_tr_type

Message ID 20230503080258.14525-7-dwagner@suse.de (mailing list archive)
State New, archived
Headers show
Series nvme testsuite runtime optimization | expand

Commit Message

Daniel Wagner May 3, 2023, 8:02 a.m. UTC
Mention that the nvme tests can be parametrized.

Signed-off-by: Daniel Wagner <dwagner@suse.de>
---
 Documentation/running-tests.md | 7 +++++++
 1 file changed, 7 insertions(+)

Comments

Chaitanya Kulkarni May 3, 2023, 9:32 a.m. UTC | #1
On 5/3/23 01:02, Daniel Wagner wrote:
> Mention that the nvme tests can be parametrized.
>
> Signed-off-by: Daniel Wagner <dwagner@suse.de>
> ---
>   Documentation/running-tests.md | 7 +++++++
>   1 file changed, 7 insertions(+)
>
> diff --git a/Documentation/running-tests.md b/Documentation/running-tests.md
> index 3550f377f487..7e827fba7ac0 100644
> --- a/Documentation/running-tests.md
> +++ b/Documentation/running-tests.md
> @@ -98,6 +98,13 @@ requires that the kernel be compiled with `CONFIG_BLK_DEV_ZONED` enabled.
>   RUN_ZONED_TESTS=1
>   ```
>   
> +### NVMe test parameterizing
> +
> +The NVMe tests can be additionally parameterized via environment variables.
> +
> +- nvme_tr_type: 'loop' (default), 'tcp', 'rdma' and 'fc'
> +  Run the tests with the given transport.
> +
>   ### Running nvme-rdma nvmeof-mp srp tests
>   
>   Most of these tests will use the rdma_rxe (soft-RoCE) driver by default. The siw (soft-iWARP) driver is also supported.

Looks good.

Reviewed-by: Chaitanya Kulkarni <kch@nvidia.com>

-ck
Shinichiro Kawasaki May 7, 2023, 11:21 p.m. UTC | #2
Oh, thank you for adding this missing piece! Please find a nit below.

On May 03, 2023 / 10:02, Daniel Wagner wrote:
> Mention that the nvme tests can be parametrized.
> 
> Signed-off-by: Daniel Wagner <dwagner@suse.de>
> ---
>  Documentation/running-tests.md | 7 +++++++
>  1 file changed, 7 insertions(+)
> 
> diff --git a/Documentation/running-tests.md b/Documentation/running-tests.md
> index 3550f377f487..7e827fba7ac0 100644
> --- a/Documentation/running-tests.md
> +++ b/Documentation/running-tests.md
> @@ -98,6 +98,13 @@ requires that the kernel be compiled with `CONFIG_BLK_DEV_ZONED` enabled.
>  RUN_ZONED_TESTS=1
>  ```
>  
> +### NVMe test parameterizing
> +
> +The NVMe tests can be additionally parameterized via environment variables.
> +
> +- nvme_tr_type: 'loop' (default), 'tcp', 'rdma' and 'fc'

nvme_tr_type should be nvme_trtype. Same for the commit title.

> +  Run the tests with the given transport.
> +
>  ### Running nvme-rdma nvmeof-mp srp tests
>  
>  Most of these tests will use the rdma_rxe (soft-RoCE) driver by default. The siw (soft-iWARP) driver is also supported.
> -- 
> 2.40.0
>
diff mbox series

Patch

diff --git a/Documentation/running-tests.md b/Documentation/running-tests.md
index 3550f377f487..7e827fba7ac0 100644
--- a/Documentation/running-tests.md
+++ b/Documentation/running-tests.md
@@ -98,6 +98,13 @@  requires that the kernel be compiled with `CONFIG_BLK_DEV_ZONED` enabled.
 RUN_ZONED_TESTS=1
 ```
 
+### NVMe test parameterizing
+
+The NVMe tests can be additionally parameterized via environment variables.
+
+- nvme_tr_type: 'loop' (default), 'tcp', 'rdma' and 'fc'
+  Run the tests with the given transport.
+
 ### Running nvme-rdma nvmeof-mp srp tests
 
 Most of these tests will use the rdma_rxe (soft-RoCE) driver by default. The siw (soft-iWARP) driver is also supported.