| Message ID | 20230517174230.897144-2-bvanassche@acm.org (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | mq-deadline: Improve support for zoned block devices | expand |
On 5/18/23 02:42, Bart Van Assche wrote: > Add the missing word "and". > > Cc: Damien Le Moal <dlemoal@kernel.org> > Suggested-by: Damien Le Moal <dlemoal@kernel.org> > Fixes: 945ffb60c11d ("mq-deadline: add blk-mq adaptation of the deadline IO scheduler") > Signed-off-by: Bart Van Assche <bvanassche@acm.org> Replying to this patch as there is no cover letter. I gave this series a spin yesterday using a 26TB SMR drive. No issues detected and no performance regression that I can see. Tested on top of 6.4-rc2. So feel free to add: Tested-by: Damien Le Moal <dlemoal@kernel.org>
On 5/18/23 16:11, Damien Le Moal wrote: > On 5/18/23 02:42, Bart Van Assche wrote: >> Add the missing word "and". >> >> Cc: Damien Le Moal <dlemoal@kernel.org> >> Suggested-by: Damien Le Moal <dlemoal@kernel.org> >> Fixes: 945ffb60c11d ("mq-deadline: add blk-mq adaptation of the deadline IO scheduler") >> Signed-off-by: Bart Van Assche <bvanassche@acm.org> > > Replying to this patch as there is no cover letter. > > I gave this series a spin yesterday using a 26TB SMR drive. No issues detected > and no performance regression that I can see. Tested on top of 6.4-rc2. > > So feel free to add: > > Tested-by: Damien Le Moal <dlemoal@kernel.org> Thanks Damien! BTW, it seems like Lore received the cover letter. See also https://lore.kernel.org/linux-block/20230517174230.897144-1-bvanassche@acm.org/T/#t. Bart.
On 5/19/23 08:20, Bart Van Assche wrote: > On 5/18/23 16:11, Damien Le Moal wrote: >> On 5/18/23 02:42, Bart Van Assche wrote: >>> Add the missing word "and". >>> >>> Cc: Damien Le Moal <dlemoal@kernel.org> >>> Suggested-by: Damien Le Moal <dlemoal@kernel.org> >>> Fixes: 945ffb60c11d ("mq-deadline: add blk-mq adaptation of the deadline IO scheduler") >>> Signed-off-by: Bart Van Assche <bvanassche@acm.org> >> >> Replying to this patch as there is no cover letter. >> >> I gave this series a spin yesterday using a 26TB SMR drive. No issues detected >> and no performance regression that I can see. Tested on top of 6.4-rc2. >> >> So feel free to add: >> >> Tested-by: Damien Le Moal <dlemoal@kernel.org> > > Thanks Damien! > > BTW, it seems like Lore received the cover letter. See also > https://lore.kernel.org/linux-block/20230517174230.897144-1-bvanassche@acm.org/T/#t. Weird... I do not have it in my inbox.. > > Bart. >
diff --git a/block/mq-deadline.c b/block/mq-deadline.c index 5839a027e0f0..cea1b084c69e 100644 --- a/block/mq-deadline.c +++ b/block/mq-deadline.c @@ -443,7 +443,7 @@ static struct request *__dd_dispatch_request(struct deadline_data *dd, */ rq = deadline_next_request(dd, per_prio, dd->last_dir); if (rq && dd->batching < dd->fifo_batch) - /* we have a next request are still entitled to batch */ + /* we have a next request and are still entitled to batch */ goto dispatch_request; /*
Add the missing word "and". Cc: Damien Le Moal <dlemoal@kernel.org> Suggested-by: Damien Le Moal <dlemoal@kernel.org> Fixes: 945ffb60c11d ("mq-deadline: add blk-mq adaptation of the deadline IO scheduler") Signed-off-by: Bart Van Assche <bvanassche@acm.org> --- block/mq-deadline.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)