| Message ID | 20231019030444.53680-1-jiapeng.chong@linux.alibaba.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | block: ublk_drv: Remove unused function | expand |
On Thu, Oct 19, 2023 at 11:04:44AM +0800, Jiapeng Chong wrote: > The function are defined in the ublk_drv.c file, but not called > elsewhere, so delete the unused function. > > drivers/block/ublk_drv.c:1211:20: warning: unused function 'ublk_abort_io_cmds'. > > Reported-by: Abaci Robot <abaci@linux.alibaba.com> > Closes: https://bugzilla.openanolis.cn/show_bug.cgi?id=6938 > Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com> Fixes: b4e1353f4651 ("ublk: simplify aborting request") Reviewed-by: Ming Lei <ming.lei@rehdat.com> Thanks, Ming
On Thu, 19 Oct 2023 11:04:44 +0800, Jiapeng Chong wrote: > The function are defined in the ublk_drv.c file, but not called > elsewhere, so delete the unused function. > > drivers/block/ublk_drv.c:1211:20: warning: unused function 'ublk_abort_io_cmds'. > > Applied, thanks! [1/1] block: ublk_drv: Remove unused function commit: 411957553bca681f6c6a64f419c352bb7d87c2a5 Best regards,
diff --git a/drivers/block/ublk_drv.c b/drivers/block/ublk_drv.c index c34474451908..83600b45e12a 100644 --- a/drivers/block/ublk_drv.c +++ b/drivers/block/ublk_drv.c @@ -1208,15 +1208,6 @@ static inline void ublk_forward_io_cmds(struct ublk_queue *ubq, __ublk_rq_task_work(blk_mq_rq_from_pdu(data), issue_flags); } -static inline void ublk_abort_io_cmds(struct ublk_queue *ubq) -{ - struct llist_node *io_cmds = llist_del_all(&ubq->io_cmds); - struct ublk_rq_data *data, *tmp; - - llist_for_each_entry_safe(data, tmp, io_cmds, node) - __ublk_abort_rq(ubq, blk_mq_rq_from_pdu(data)); -} - static void ublk_rq_task_work_cb(struct io_uring_cmd *cmd, unsigned issue_flags) { struct ublk_uring_cmd_pdu *pdu = ublk_get_uring_cmd_pdu(cmd);
The function are defined in the ublk_drv.c file, but not called elsewhere, so delete the unused function. drivers/block/ublk_drv.c:1211:20: warning: unused function 'ublk_abort_io_cmds'. Reported-by: Abaci Robot <abaci@linux.alibaba.com> Closes: https://bugzilla.openanolis.cn/show_bug.cgi?id=6938 Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com> --- drivers/block/ublk_drv.c | 9 --------- 1 file changed, 9 deletions(-)