diff mbox series

[v2] block: skip QUEUE_FLAG_STATS and rq-qos for passthrough io

Message ID 20231123190331.7934-1-kundan.kumar@samsung.com (mailing list archive)
State New, archived
Headers show
Series [v2] block: skip QUEUE_FLAG_STATS and rq-qos for passthrough io | expand

Commit Message

Kundan Kumar Nov. 23, 2023, 7:03 p.m. UTC 
From: Kundan Kumar <kundan.kumar@samsung.com>

Write-back throttling (WBT) enables QUEUE_FLAG_STATS on the request
queue. But WBT does not make sense for passthrough io, so skip
QUEUE_FLAG_STATS processing.

Also skip rq_qos_issue/done for passthrough io.

Overall, the change gives ~11% hike in peak performance.

Signed-off-by: Kundan Kumar <kundan.kumar@samsung.com>
Signed-off-by: Kanchan Joshi <joshi.k@samsung.com>
---
Changes since v1:
- Fix coding style

 block/blk-mq.c     | 3 ++-
 block/blk-rq-qos.h | 2 +-
 2 files changed, 3 insertions(+), 2 deletions(-)

Comments

Jens Axboe Dec. 1, 2023, 2:31 p.m. UTC | #1 
On Fri, 24 Nov 2023 00:33:31 +0530, kundan.kumar wrote:
> Write-back throttling (WBT) enables QUEUE_FLAG_STATS on the request
> queue. But WBT does not make sense for passthrough io, so skip
> QUEUE_FLAG_STATS processing.
> 
> Also skip rq_qos_issue/done for passthrough io.
> 
> Overall, the change gives ~11% hike in peak performance.
> 
> [...]

Applied, thanks!

[1/1] block: skip QUEUE_FLAG_STATS and rq-qos for passthrough io
      commit: 6e2d4b77c252b6f6e47dadf1ceaeee4ebe97eff4

Best regards,
diff mbox series

Patch

diff --git a/block/blk-mq.c b/block/blk-mq.c
index 900c1be1fee1..fb29ff5cc281 100644
--- a/block/blk-mq.c
+++ b/block/blk-mq.c
@@ -1248,7 +1248,8 @@  void blk_mq_start_request(struct request *rq)
 
 	trace_block_rq_issue(rq);
 
-	if (test_bit(QUEUE_FLAG_STATS, &q->queue_flags)) {
+	if (test_bit(QUEUE_FLAG_STATS, &q->queue_flags) &&
+	    !blk_rq_is_passthrough(rq)) {
 		rq->io_start_time_ns = ktime_get_ns();
 		rq->stats_sectors = blk_rq_sectors(rq);
 		rq->rq_flags |= RQF_STATS;
diff --git a/block/blk-rq-qos.h b/block/blk-rq-qos.h
index f48ee150d667..37245c97ee61 100644
--- a/block/blk-rq-qos.h
+++ b/block/blk-rq-qos.h
@@ -118,7 +118,7 @@  static inline void rq_qos_cleanup(struct request_queue *q, struct bio *bio)
 
 static inline void rq_qos_done(struct request_queue *q, struct request *rq)
 {
-	if (q->rq_qos)
+	if (q->rq_qos && !blk_rq_is_passthrough(rq))
 		__rq_qos_done(q->rq_qos, rq);
 }