| Message ID | 20231226081524.180289-1-hch@lst.de (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | block: renumber QUEUE_FLAG_HW_WC | expand |
On 12/26/23 1:15 AM, Christoph Hellwig wrote: > For the QUEUE_FLAG_HW_WC to actually work, it needs to have a separate > number from QUEUE_FLAG_FUA, doh. > > Fixes: ebed8639d51b ("block: don't allow enabling a cache on devices that don't support it") Not sure where that is from? Fixed it up to: Fixes: 43c9835b144c ("block: don't allow enabling a cache on devices that don't support it")
On Tue, 26 Dec 2023 08:15:24 +0000, Christoph Hellwig wrote: > For the QUEUE_FLAG_HW_WC to actually work, it needs to have a separate > number from QUEUE_FLAG_FUA, doh. > > Applied, thanks! [1/1] block: renumber QUEUE_FLAG_HW_WC (no commit info) Best regards,
diff --git a/include/linux/blkdev.h b/include/linux/blkdev.h index bc236e77d85e1c..ce1ab712552e3c 100644 --- a/include/linux/blkdev.h +++ b/include/linux/blkdev.h @@ -521,7 +521,7 @@ struct request_queue { #define QUEUE_FLAG_ADD_RANDOM 10 /* Contributes to random pool */ #define QUEUE_FLAG_SYNCHRONOUS 11 /* always completes in submit context */ #define QUEUE_FLAG_SAME_FORCE 12 /* force complete on same CPU */ -#define QUEUE_FLAG_HW_WC 18 /* Write back caching supported */ +#define QUEUE_FLAG_HW_WC 13 /* Write back caching supported */ #define QUEUE_FLAG_INIT_DONE 14 /* queue is initialized */ #define QUEUE_FLAG_STABLE_WRITES 15 /* don't modify blks until WB is done */ #define QUEUE_FLAG_POLL 16 /* IO polling enabled if set */
For the QUEUE_FLAG_HW_WC to actually work, it needs to have a separate number from QUEUE_FLAG_FUA, doh. Fixes: ebed8639d51b ("block: don't allow enabling a cache on devices that don't support it") Signed-off-by: Christoph Hellwig <hch@lst.de> --- include/linux/blkdev.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)