diff mbox series

blk-throttle: Eliminate redundant checks for data direction

Message ID 20240123081248.3752878-1-yizhou.tang@shopee.com (mailing list archive)
State New, archived
Headers show
Series blk-throttle: Eliminate redundant checks for data direction | expand

Commit Message

Tang Yizhou Jan. 23, 2024, 8:12 a.m. UTC 
From: Tang Yizhou <yizhou.tang@shopee.com>

After calling throtl_peek_queued(), the data direction can be determined so
there is no need to call bio_data_dir() to check the direction again.

Signed-off-by: Tang Yizhou <yizhou.tang@shopee.com>
---
 block/blk-throttle.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

Comments

Christoph Hellwig Jan. 23, 2024, 8:46 a.m. UTC | #1 
Looks good:

Reviewed-by: Christoph Hellwig <hch@lst.de>
Jens Axboe Feb. 5, 2024, 5:16 p.m. UTC | #2 
On Tue, 23 Jan 2024 16:12:48 +0800, Tang Yizhou wrote:
> After calling throtl_peek_queued(), the data direction can be determined so
> there is no need to call bio_data_dir() to check the direction again.
> 
> 

Applied, thanks!

[1/1] blk-throttle: Eliminate redundant checks for data direction
      commit: 3bca7640b4c50621b94365a1746f4b86116fec56

Best regards,
diff mbox series

Patch

diff --git a/block/blk-throttle.c b/block/blk-throttle.c
index 16f5766620a4..2ad4f6cd465b 100644
--- a/block/blk-throttle.c
+++ b/block/blk-throttle.c
@@ -1098,7 +1098,7 @@  static int throtl_dispatch_tg(struct throtl_grp *tg)
 	while ((bio = throtl_peek_queued(&sq->queued[READ])) &&
 	       tg_may_dispatch(tg, bio, NULL)) {
 
-		tg_dispatch_one_bio(tg, bio_data_dir(bio));
+		tg_dispatch_one_bio(tg, READ);
 		nr_reads++;
 
 		if (nr_reads >= max_nr_reads)
@@ -1108,7 +1108,7 @@  static int throtl_dispatch_tg(struct throtl_grp *tg)
 	while ((bio = throtl_peek_queued(&sq->queued[WRITE])) &&
 	       tg_may_dispatch(tg, bio, NULL)) {
 
-		tg_dispatch_one_bio(tg, bio_data_dir(bio));
+		tg_dispatch_one_bio(tg, WRITE);
 		nr_writes++;
 
 		if (nr_writes >= max_nr_writes)