diff mbox series

[blktests] nbd/001: wait for the device node to show up before running parted

Message ID 20240229143427.1046807-1-hch@lst.de (mailing list archive)
State New, archived
Headers show
Series [blktests] nbd/001: wait for the device node to show up before running parted | expand

Commit Message

Christoph Hellwig Feb. 29, 2024, 2:34 p.m. UTC
The parted call can happen before the device is settled and thus fail.
Currently this happens very rarely for me (about 1 in 500 runs), but
a pending change to freeze the queues for updating the limits will make
it much more likely to hit.

Signed-off-by: Christoph Hellwig <hch@lst.de>
---
 tests/nbd/001 | 2 ++
 1 file changed, 2 insertions(+)

Comments

Shinichiro Kawasaki March 1, 2024, 11:51 a.m. UTC | #1
On Feb 29, 2024 / 06:34, Christoph Hellwig wrote:
> The parted call can happen before the device is settled and thus fail.
> Currently this happens very rarely for me (about 1 in 500 runs), but
> a pending change to freeze the queues for updating the limits will make
> it much more likely to hit.
> 
> Signed-off-by: Christoph Hellwig <hch@lst.de>

Applied, thanks!
diff mbox series

Patch

diff --git a/tests/nbd/001 b/tests/nbd/001
index 9427f8e..5fd0d43 100755
--- a/tests/nbd/001
+++ b/tests/nbd/001
@@ -18,6 +18,8 @@  test() {
 	echo "Running ${TEST_NAME}"
 	_start_nbd_server
 	nbd-client -L -N export localhost /dev/nbd0 >> "$FULL" 2>&1
+	udevadm settle
+
 	parted -s /dev/nbd0 print 2>> "$FULL" | grep 'Disk /dev/nbd0'
 	lsblk --raw --noheadings /dev/nbd0