diff mbox series

[blktests,v1,11/18] nvme/rc: remove correct port from target

Message ID 20240321094727.6503-12-dwagner@suse.de (mailing list archive)
State New, archived
Headers show
Series refactoring and various cleanups/fixes | expand

Commit Message

Daniel Wagner March 21, 2024, 9:47 a.m. UTC
Remove the port from the subsystem the test wants to remove.

Fixes: a12281b8320f ("nvme: introduce nvmet_target_{setup/cleanup} common code")
Signed-off-by: Daniel Wagner <dwagner@suse.de>
---
 tests/nvme/rc | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Shin'ichiro Kawasaki March 22, 2024, 9:19 a.m. UTC | #1
On Mar 21, 2024 / 10:47, Daniel Wagner wrote:
> Remove the port from the subsystem the test wants to remove.
> 
> Fixes: a12281b8320f ("nvme: introduce nvmet_target_{setup/cleanup} common code")

I'm not sure if this Fixes tag is correct. IIUC, the change in this patch is a
missed hank in the 9th patch.

> Signed-off-by: Daniel Wagner <dwagner@suse.de>
> ---
>  tests/nvme/rc | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/tests/nvme/rc b/tests/nvme/rc
> index ba83f32febb8..d74a5418557d 100644
> --- a/tests/nvme/rc
> +++ b/tests/nvme/rc
> @@ -869,7 +869,7 @@ _nvmet_target_cleanup() {
>  		esac
>  	done
>  
> -	_get_nvmet_ports "${def_subsysnqn}" ports
> +	_get_nvmet_ports "${subsysnqn}" ports
>  
>  	for port in "${ports[@]}"; do
>  		_remove_nvmet_subsystem_from_port "${port}" "${subsysnqn}"
> -- 
> 2.44.0
>
diff mbox series

Patch

diff --git a/tests/nvme/rc b/tests/nvme/rc
index ba83f32febb8..d74a5418557d 100644
--- a/tests/nvme/rc
+++ b/tests/nvme/rc
@@ -869,7 +869,7 @@  _nvmet_target_cleanup() {
 		esac
 	done
 
-	_get_nvmet_ports "${def_subsysnqn}" ports
+	_get_nvmet_ports "${subsysnqn}" ports
 
 	for port in "${ports[@]}"; do
 		_remove_nvmet_subsystem_from_port "${port}" "${subsysnqn}"