@@ -53,7 +53,7 @@ test_device() {
_nvmet_passthru_target_setup "${def_subsysnqn}"
- nsdev=$(_nvmet_passthru_target_connect "${nvme_trtype}" "${def_subsysnqn}")
+ nsdev=$(_nvmet_passthru_target_connect "${def_subsysnqn}")
compare_dev_info "${nsdev}"
@@ -23,7 +23,7 @@ test_device() {
local nsdev
_nvmet_passthru_target_setup "${def_subsysnqn}"
- nsdev=$(_nvmet_passthru_target_connect "${nvme_trtype}" "${def_subsysnqn}")
+ nsdev=$(_nvmet_passthru_target_connect "${def_subsysnqn}")
_run_fio_verify_io --size="${nvme_img_size}" --filename="${nsdev}"
@@ -29,7 +29,7 @@ test_device() {
local nsdev
_nvmet_passthru_target_setup "${def_subsysnqn}"
- nsdev=$(_nvmet_passthru_target_connect "${nvme_trtype}" "${def_subsysnqn}")
+ nsdev=$(_nvmet_passthru_target_connect "${def_subsysnqn}")
if ! _xfs_run_fio_verify_io "${nsdev}" "${nvme_img_size}"; then
echo "FAIL: fio verify failed"
@@ -21,7 +21,7 @@ test_device() {
local ctrldev
_nvmet_passthru_target_setup "${def_subsysnqn}"
- nsdev=$(_nvmet_passthru_target_connect "${nvme_trtype}" "${def_subsysnqn}")
+ nsdev=$(_nvmet_passthru_target_connect "${def_subsysnqn}")
ctrldev=$(_find_nvme_dev "${def_subsysnqn}")
@@ -23,8 +23,7 @@ test_device() {
for ((i = 0; i < iterations; i++)); do
_nvmet_passthru_target_setup "${subsys}${i}"
- nsdev=$(_nvmet_passthru_target_connect "${nvme_trtype}" \
- "${subsys}${i}")
+ nsdev=$(_nvmet_passthru_target_connect "${subsys}${i}")
_nvme_disconnect_subsys "${subsys}${i}" >>"${FULL}" 2>&1
_nvmet_passthru_target_cleanup "${subsys}${i}"
@@ -897,8 +897,7 @@ _nvmet_passthru_target_setup() {
}
_nvmet_passthru_target_connect() {
- local trtype=$1
- local subsys_name=$2
+ local subsys_name=$1
_nvme_connect_subsys "${subsys_name}" --no-wait || return
nsdev=$(_find_nvme_passthru_loop_dev "${subsys_name}")
Every invocation of _nvmet_passthru_target_connect passes in the default nvme_trtype argument. The argument is not evaluated anymore, thus just remove it. Signed-off-by: Daniel Wagner <dwagner@suse.de> --- tests/nvme/033 | 2 +- tests/nvme/034 | 2 +- tests/nvme/035 | 2 +- tests/nvme/036 | 2 +- tests/nvme/037 | 3 +-- tests/nvme/rc | 3 +-- 6 files changed, 6 insertions(+), 8 deletions(-)