From patchwork Tue Mar 26 13:14:00 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Daniel Wagner X-Patchwork-Id: 13604123 Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.223.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9A0BB74411 for ; Tue, 26 Mar 2024 13:14:18 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=195.135.223.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1711458860; cv=none; b=YAI2NEsSP2mwWLrGjbk+by9QWHQ+N07EJ5Zxz6sn5Y8K36r76dR5bnssJAIoJRmXGhADX2z7jTHQW+y/3t54gWmcGT/V95tBiEMwfTY6hFOXHaikm5MVtOBzszNmmrCMvDog0WdcgYExNBgbHqcri3bTi4PVnQxnL0XO2CrY6zU= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1711458860; c=relaxed/simple; bh=4bpSVLZdZpyIxbCq/ZqQb9QaMFYJMevz+2v3LoSG2kE=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=Uj53zYFVDiI6ez3lCL+YTpo5+/lToGkPmyABK8QCidfUkR6VcbmcymirZRQ0eqyMq1JLFVlWHfPxhWTj0FFraks/ZpCcsM4gdH49eTSCagtJdVlfUqO2qq2JjqCRudTVPK18IINEry/FYIVmoufmXRFWQ9bABZL49NQW8Qumz2s= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=suse.de; spf=pass smtp.mailfrom=suse.de; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b=A6xhVg1C; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b=rnfZ+vc+; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b=A6xhVg1C; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b=rnfZ+vc+; arc=none smtp.client-ip=195.135.223.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=suse.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=suse.de Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b="A6xhVg1C"; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b="rnfZ+vc+"; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b="A6xhVg1C"; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b="rnfZ+vc+" Received: from imap2.dmz-prg2.suse.org (imap2.dmz-prg2.suse.org [IPv6:2a07:de40:b281:104:10:150:64:98]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id D722F5D64E; Tue, 26 Mar 2024 13:14:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1711458856; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=RRwxPcjUmT+sgVYhBELtu/T0gPthLZogcmVoqBFq7L4=; b=A6xhVg1CWJw6Wt6xqXWvj5a87reerCzbNxNeKOyVWgFY0E+wxeeFJavKAMD7vJYT6by/LK ZSILSfJIMTgXZS0w8bnhEikd7ZfNDFfic1Ib11Enw0BwEWawreXMY3+w9uNKrT1mGV5DMz SmmzVWxNnZNDwESl2qUhpdYEV5DnGyE= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1711458856; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=RRwxPcjUmT+sgVYhBELtu/T0gPthLZogcmVoqBFq7L4=; b=rnfZ+vc+cYU/neNEZyf2A/tzpS67KHHIH/o1xVTWJbWWp495KYpZvD/Dusq4K31YCtOKIB LW7kPufA5APX+nAw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1711458856; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=RRwxPcjUmT+sgVYhBELtu/T0gPthLZogcmVoqBFq7L4=; b=A6xhVg1CWJw6Wt6xqXWvj5a87reerCzbNxNeKOyVWgFY0E+wxeeFJavKAMD7vJYT6by/LK ZSILSfJIMTgXZS0w8bnhEikd7ZfNDFfic1Ib11Enw0BwEWawreXMY3+w9uNKrT1mGV5DMz SmmzVWxNnZNDwESl2qUhpdYEV5DnGyE= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1711458856; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=RRwxPcjUmT+sgVYhBELtu/T0gPthLZogcmVoqBFq7L4=; b=rnfZ+vc+cYU/neNEZyf2A/tzpS67KHHIH/o1xVTWJbWWp495KYpZvD/Dusq4K31YCtOKIB LW7kPufA5APX+nAw== Received: from imap2.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap2.dmz-prg2.suse.org (Postfix) with ESMTPS id C57F313587; Tue, 26 Mar 2024 13:14:16 +0000 (UTC) Received: from dovecot-director2.suse.de ([10.150.64.162]) by imap2.dmz-prg2.suse.org with ESMTPSA id ay/ELijKAmYmNwAAn2gu4w (envelope-from ); Tue, 26 Mar 2024 13:14:16 +0000 From: Daniel Wagner To: Shin'ichiro Kawasaki Cc: linux-block@vger.kernel.org, linux-nvme@lists.infradead.org, Chaitanya Kulkarni , Hannes Reinecke , Daniel Wagner Subject: [PATCH blktests v3 18/20] nvme/{041,042,043,044,045,048}: do not pass default host{nqn|id} to _nvme_connect_subsys Date: Tue, 26 Mar 2024 14:14:00 +0100 Message-ID: <20240326131402.5092-19-dwagner@suse.de> X-Mailer: git-send-email 2.44.0 In-Reply-To: <20240326131402.5092-1-dwagner@suse.de> References: <20240326131402.5092-1-dwagner@suse.de> Precedence: bulk X-Mailing-List: linux-block@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-Spam-Score: -3.01 X-Rspamd-Server: rspamd1.dmz-prg2.suse.org X-Spam-Flag: NO X-Spamd-Result: default: False [-3.01 / 50.00]; RCVD_VIA_SMTP_AUTH(0.00)[]; SPAMHAUS_XBL(0.00)[2a07:de40:b281:104:10:150:64:98:from]; TO_DN_SOME(0.00)[]; R_MISSING_CHARSET(2.50)[]; BROKEN_CONTENT_TYPE(1.50)[]; RCPT_COUNT_FIVE(0.00)[6]; R_RATELIMIT(0.00)[to_ip_from(RL7ufrgpbk1ee76mmzdtnzc641)]; RCVD_COUNT_THREE(0.00)[3]; DKIM_TRACE(0.00)[suse.de:+]; MX_GOOD(-0.01)[]; NEURAL_HAM_SHORT(-0.20)[-1.000]; FROM_EQ_ENVFROM(0.00)[]; MIME_TRACE(0.00)[0:+]; BAYES_HAM(-3.00)[100.00%]; ARC_NA(0.00)[]; R_DKIM_ALLOW(-0.20)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; FROM_HAS_DN(0.00)[]; TO_MATCH_ENVRCPT_ALL(0.00)[]; NEURAL_HAM_LONG(-1.00)[-1.000]; MIME_GOOD(-0.10)[text/plain]; DWL_DNSWL_HI(-3.50)[suse.de:dkim]; DKIM_SIGNED(0.00)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; MID_CONTAINS_FROM(1.00)[]; DBL_BLOCKED_OPENRESOLVER(0.00)[suse.de:dkim,suse.de:email]; FUZZY_BLOCKED(0.00)[rspamd.com]; RCVD_TLS_ALL(0.00)[]; RBL_SPAMHAUS_BLOCKED_OPENRESOLVER(0.00)[2a07:de40:b281:104:10:150:64:98:from] X-Spam-Level: Authentication-Results: smtp-out2.suse.de; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=A6xhVg1C; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=rnfZ+vc+ X-Rspamd-Queue-Id: D722F5D64E There is no point in passing the default values to _nvme_connect_subsys, thus drop these arguments. Signed-off-by: Daniel Wagner --- tests/nvme/041 | 7 ++----- tests/nvme/042 | 8 ++------ tests/nvme/043 | 8 ++------ tests/nvme/044 | 16 ++++------------ tests/nvme/045 | 4 +--- tests/nvme/048 | 4 +--- 6 files changed, 12 insertions(+), 35 deletions(-) diff --git a/tests/nvme/041 b/tests/nvme/041 index d6845628726e..f1fa00c0f420 100755 --- a/tests/nvme/041 +++ b/tests/nvme/041 @@ -38,16 +38,13 @@ test() { # Test unauthenticated connection (should fail) echo "Test unauthenticated connection (should fail)" - _nvme_connect_subsys --hostnqn "${def_hostnqn}" \ - --hostid "${def_hostid}" + _nvme_connect_subsys _nvme_disconnect_subsys # Test authenticated connection echo "Test authenticated connection" - _nvme_connect_subsys --hostnqn "${def_hostnqn}" \ - --hostid "${def_hostid}" \ - --dhchap-secret "${hostkey}" + _nvme_connect_subsys --dhchap-secret "${hostkey}" _nvme_disconnect_subsys diff --git a/tests/nvme/042 b/tests/nvme/042 index 480e1cba9d19..a9e79c6a13b4 100755 --- a/tests/nvme/042 +++ b/tests/nvme/042 @@ -41,9 +41,7 @@ test() { fi _set_nvmet_hostkey "${def_hostnqn}" "${hostkey}" - _nvme_connect_subsys --hostnqn "${def_hostnqn}" \ - --hostid "${def_hostid}" \ - --dhchap-secret "${hostkey}" + _nvme_connect_subsys --dhchap-secret "${hostkey}" _nvme_disconnect_subsys done @@ -57,9 +55,7 @@ test() { fi _set_nvmet_hostkey "${def_hostnqn}" "${hostkey}" - _nvme_connect_subsys --hostnqn "${def_hostnqn}" \ - --hostid "${def_hostid}" \ - --dhchap-secret "${hostkey}" + _nvme_connect_subsys --dhchap-secret "${hostkey}" _nvme_disconnect_subsys done diff --git a/tests/nvme/043 b/tests/nvme/043 index dd48035dd967..4589423d4335 100755 --- a/tests/nvme/043 +++ b/tests/nvme/043 @@ -45,9 +45,7 @@ test() { _set_nvmet_hash "${def_hostnqn}" "${hash}" - _nvme_connect_subsys --hostnqn "${def_hostnqn}" \ - --hostid "${def_hostid}" \ - --dhchap-secret "${hostkey}" + _nvme_connect_subsys --dhchap-secret "${hostkey}" _nvme_disconnect_subsys done @@ -58,9 +56,7 @@ test() { _set_nvmet_dhgroup "${def_hostnqn}" "${dhgroup}" - _nvme_connect_subsys --hostnqn "${def_hostnqn}" \ - --hostid "${def_hostid}" \ - --dhchap-secret "${hostkey}" + _nvme_connect_subsys --dhchap-secret "${hostkey}" _nvme_disconnect_subsys done diff --git a/tests/nvme/044 b/tests/nvme/044 index 624b832c0cc6..8b8859068660 100755 --- a/tests/nvme/044 +++ b/tests/nvme/044 @@ -49,18 +49,14 @@ test() { # Step 1: Connect with host authentication only echo "Test host authentication" - _nvme_connect_subsys --hostnqn "${def_hostnqn}" \ - --hostid "${def_hostid}" \ - --dhchap-secret "${hostkey}" + _nvme_connect_subsys --dhchap-secret "${hostkey}" _nvme_disconnect_subsys # Step 2: Connect with host authentication # and invalid ctrl authentication echo "Test invalid ctrl authentication (should fail)" - _nvme_connect_subsys --hostnqn "${def_hostnqn}" \ - --hostid "${def_hostid}" \ - --dhchap-secret "${hostkey}" \ + _nvme_connect_subsys --dhchap-secret "${hostkey}" \ --dhchap-ctrl-secret "${hostkey}" _nvme_disconnect_subsys @@ -68,9 +64,7 @@ test() { # Step 3: Connect with host authentication # and valid ctrl authentication echo "Test valid ctrl authentication" - _nvme_connect_subsys --hostnqn "${def_hostnqn}" \ - --hostid "${def_hostid}" \ - --dhchap-secret "${hostkey}" \ + _nvme_connect_subsys --dhchap-secret "${hostkey}" \ --dhchap-ctrl-secret "${ctrlkey}" _nvme_disconnect_subsys @@ -79,9 +73,7 @@ test() { # and invalid ctrl key echo "Test invalid ctrl key (should fail)" invkey="DHHC-1:00:Jc/My1o0qtLCWRp+sHhAVafdfaS7YQOMYhk9zSmlatobqB8C:" - _nvme_connect_subsys --hostnqn "${def_hostnqn}" \ - --hostid "${def_hostid}" \ - --dhchap-secret "${hostkey}" \ + _nvme_connect_subsys --dhchap-secret "${hostkey}" \ --dhchap-ctrl-secret "${invkey}" _nvme_disconnect_subsys diff --git a/tests/nvme/045 b/tests/nvme/045 index 3a5df7c0946c..87ac3c019970 100755 --- a/tests/nvme/045 +++ b/tests/nvme/045 @@ -51,9 +51,7 @@ test() { _set_nvmet_dhgroup "${def_hostnqn}" "ffdhe2048" - _nvme_connect_subsys --hostnqn "${def_hostnqn}" \ - --hostid "${def_hostid}" \ - --dhchap-secret "${hostkey}" \ + _nvme_connect_subsys --dhchap-secret "${hostkey}" \ --dhchap-ctrl-secret "${ctrlkey}" echo "Re-authenticate with original host key" diff --git a/tests/nvme/048 b/tests/nvme/048 index 79620e0d0879..0b299a91288b 100755 --- a/tests/nvme/048 +++ b/tests/nvme/048 @@ -99,9 +99,7 @@ test() { _nvmet_target_setup --blkdev file if [[ -f "${cfs_path}/attr_qid_max" ]] ; then - _nvme_connect_subsys --hostnqn "${def_hostnqn}" \ - --hostid "${def_hostid}" \ - --keep-alive-tmo 1 \ + _nvme_connect_subsys --keep-alive-tmo 1 \ --reconnect-delay 2 if ! nvmf_wait_for_state "${def_subsysnqn}" "live" ; then