| Message ID | 20240328084147.2954434-2-hch@lst.de (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | [1/4] block: add a bio_list_merge_init helper | expand |
On 3/28/24 04:41, Christoph Hellwig wrote: > This is a simple combination of bio_list_merge + bio_list_init > similar to list_splice_init. While it only saves a single > line in a callers, it makes the move all bios from one list to > another and reinitialize the original pattern a lot more obvious > in the callers. > > Signed-off-by: Christoph Hellwig <hch@lst.de> > --- > include/linux/bio.h | 7 +++++++ > 1 file changed, 7 insertions(+) > > diff --git a/include/linux/bio.h b/include/linux/bio.h > index 875d792bffff82..9b8a369f44bc6b 100644 > --- a/include/linux/bio.h > +++ b/include/linux/bio.h > @@ -615,6 +615,13 @@ static inline void bio_list_merge(struct bio_list *bl, struct bio_list *bl2) > bl->tail = bl2->tail; > } > > +static inline void bio_list_merge_init(struct bio_list *bl, > + struct bio_list *bl2) Nit: The indentation in this line looks off to me. Otherwise, for the series: Reviewed-by: Matthew Sakai <msakai@redhat.com> > +{ > + bio_list_merge(bl, bl2); > + bio_list_init(bl2); > +} > + > static inline void bio_list_merge_head(struct bio_list *bl, > struct bio_list *bl2) > {
diff --git a/include/linux/bio.h b/include/linux/bio.h index 875d792bffff82..9b8a369f44bc6b 100644 --- a/include/linux/bio.h +++ b/include/linux/bio.h @@ -615,6 +615,13 @@ static inline void bio_list_merge(struct bio_list *bl, struct bio_list *bl2) bl->tail = bl2->tail; } +static inline void bio_list_merge_init(struct bio_list *bl, + struct bio_list *bl2) +{ + bio_list_merge(bl, bl2); + bio_list_init(bl2); +} + static inline void bio_list_merge_head(struct bio_list *bl, struct bio_list *bl2) {
This is a simple combination of bio_list_merge + bio_list_init similar to list_splice_init. While it only saves a single line in a callers, it makes the move all bios from one list to another and reinitialize the original pattern a lot more obvious in the callers. Signed-off-by: Christoph Hellwig <hch@lst.de> --- include/linux/bio.h | 7 +++++++ 1 file changed, 7 insertions(+)