| Message ID | 20240504081448.1107562-13-shinichiro.kawasaki@wdc.com (mailing list archive) |
|---|---|
| State | New |
| Headers | show |
| Series | support test case repeat by different conditions | expand |
On Sat, May 04, 2024 at 05:14:43PM GMT, Shin'ichiro Kawasaki wrote: > Enable repeated test runs for the listed test cases for > NVMET_BLKDEV_TYPES. The default values of NVMET_BLKDEV_TYPES is > "device file". With this default set up, each of the listed test cases > are run twice. The second runs of the test cases for 'file' blkdev type > do exact same test as other test cases nvme/007, 009, 011, 013, 015, 020 > and 024. > > The test cases already support the repetition for NVMET_TRTYPES. Modify > the set_conditions() hooks to call both NVMET_BLKDEV_TYPES and > NVMET_TRTYPES using _set_combined_conditions(). When NVMET_BLKDEV_TYPES > and NVMET_TRTYPES are set as follows, the test cases are repeated > 2 x 3 = 6 times each. > > NVMET_BLKDEV_TYPES="device file" > NVMET_TRTYPES="loop rdma tcp" > > Signed-off-by: Shin'ichiro Kawasaki <shinichiro.kawasaki@wdc.com> Reviewed-by: Daniel Wagner <dwagner@suse.de>
diff --git a/tests/nvme/006 b/tests/nvme/006 index ff0a9eb..3f9d209 100755 --- a/tests/nvme/006 +++ b/tests/nvme/006 @@ -16,7 +16,7 @@ requires() { } set_conditions() { - _set_nvme_trtype "$@" + _set_combined_conditions _set_nvme_trtype _set_nvmet_blkdev_type "$@" } test() { diff --git a/tests/nvme/008 b/tests/nvme/008 index 1877d8a..247850c 100755 --- a/tests/nvme/008 +++ b/tests/nvme/008 @@ -16,7 +16,7 @@ requires() { } set_conditions() { - _set_nvme_trtype "$@" + _set_combined_conditions _set_nvme_trtype _set_nvmet_blkdev_type "$@" } test() { diff --git a/tests/nvme/010 b/tests/nvme/010 index 34914a7..c16587f 100755 --- a/tests/nvme/010 +++ b/tests/nvme/010 @@ -16,7 +16,7 @@ requires() { } set_conditions() { - _set_nvme_trtype "$@" + _set_combined_conditions _set_nvme_trtype _set_nvmet_blkdev_type "$@" } test() { diff --git a/tests/nvme/012 b/tests/nvme/012 index e06bf8d..e6674e2 100755 --- a/tests/nvme/012 +++ b/tests/nvme/012 @@ -20,7 +20,7 @@ requires() { } set_conditions() { - _set_nvme_trtype "$@" + _set_combined_conditions _set_nvme_trtype _set_nvmet_blkdev_type "$@" } test() { diff --git a/tests/nvme/014 b/tests/nvme/014 index ff0ebfb..571c6f4 100755 --- a/tests/nvme/014 +++ b/tests/nvme/014 @@ -16,7 +16,7 @@ requires() { } set_conditions() { - _set_nvme_trtype "$@" + _set_combined_conditions _set_nvme_trtype _set_nvmet_blkdev_type "$@" } test() { diff --git a/tests/nvme/019 b/tests/nvme/019 index 31020d9..501256c 100755 --- a/tests/nvme/019 +++ b/tests/nvme/019 @@ -16,7 +16,7 @@ requires() { } set_conditions() { - _set_nvme_trtype "$@" + _set_combined_conditions _set_nvme_trtype _set_nvmet_blkdev_type "$@" } test() { diff --git a/tests/nvme/023 b/tests/nvme/023 index da99406..3c43c55 100755 --- a/tests/nvme/023 +++ b/tests/nvme/023 @@ -16,7 +16,7 @@ requires() { } set_conditions() { - _set_nvme_trtype "$@" + _set_combined_conditions _set_nvme_trtype _set_nvmet_blkdev_type "$@" } test() {
Enable repeated test runs for the listed test cases for NVMET_BLKDEV_TYPES. The default values of NVMET_BLKDEV_TYPES is "device file". With this default set up, each of the listed test cases are run twice. The second runs of the test cases for 'file' blkdev type do exact same test as other test cases nvme/007, 009, 011, 013, 015, 020 and 024. The test cases already support the repetition for NVMET_TRTYPES. Modify the set_conditions() hooks to call both NVMET_BLKDEV_TYPES and NVMET_TRTYPES using _set_combined_conditions(). When NVMET_BLKDEV_TYPES and NVMET_TRTYPES are set as follows, the test cases are repeated 2 x 3 = 6 times each. NVMET_BLKDEV_TYPES="device file" NVMET_TRTYPES="loop rdma tcp" Signed-off-by: Shin'ichiro Kawasaki <shinichiro.kawasaki@wdc.com> --- tests/nvme/006 | 2 +- tests/nvme/008 | 2 +- tests/nvme/010 | 2 +- tests/nvme/012 | 2 +- tests/nvme/014 | 2 +- tests/nvme/019 | 2 +- tests/nvme/023 | 2 +- 7 files changed, 7 insertions(+), 7 deletions(-)