| Message ID | 20240624173835.76753-1-hch@lst.de (mailing list archive) |
|---|---|
| State | New |
| Headers | show |
| Series | block: fix the blk_queue_nonrot polarity | expand |
On 6/24/24 10:38 AM, Christoph Hellwig wrote: > Take care of the inverse polarity of the BLK_FEAT_ROTATIONAL flag > vs the old nonrot helper. > > Fixes: bd4a633b6f7c ("block: move the nonrot flag to queue_limits") > Reported-by: kernel test robot <oliver.sang@intel.com> > Reported-by: Keith Busch <kbusch@kernel.org> > Signed-off-by: Christoph Hellwig <hch@lst.de> > --- > include/linux/blkdev.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/include/linux/blkdev.h b/include/linux/blkdev.h > index 69b108a98b84c1..4a56ebf28da6ed 100644 > --- a/include/linux/blkdev.h > +++ b/include/linux/blkdev.h > @@ -617,7 +617,7 @@ bool blk_queue_flag_test_and_set(unsigned int flag, struct request_queue *q); > #define blk_queue_nomerges(q) test_bit(QUEUE_FLAG_NOMERGES, &(q)->queue_flags) > #define blk_queue_noxmerges(q) \ > test_bit(QUEUE_FLAG_NOXMERGES, &(q)->queue_flags) > -#define blk_queue_nonrot(q) ((q)->limits.features & BLK_FEAT_ROTATIONAL) > +#define blk_queue_nonrot(q) (!((q)->limits.features & BLK_FEAT_ROTATIONAL)) > #define blk_queue_io_stat(q) ((q)->limits.features & BLK_FEAT_IO_STAT) > #define blk_queue_zone_resetall(q) \ > ((q)->limits.features & BLK_FEAT_ZONE_RESETALL) Reviewed-by: Bart Van Assche <bvanassche@acm.org>
On Mon, 24 Jun 2024 19:38:35 +0200, Christoph Hellwig wrote: > Take care of the inverse polarity of the BLK_FEAT_ROTATIONAL flag > vs the old nonrot helper. > > Applied, thanks! [1/1] block: fix the blk_queue_nonrot polarity commit: 44348870de4b8f292f97b84583a298d66fbaf738 Best regards,
diff --git a/include/linux/blkdev.h b/include/linux/blkdev.h index 69b108a98b84c1..4a56ebf28da6ed 100644 --- a/include/linux/blkdev.h +++ b/include/linux/blkdev.h @@ -617,7 +617,7 @@ bool blk_queue_flag_test_and_set(unsigned int flag, struct request_queue *q); #define blk_queue_nomerges(q) test_bit(QUEUE_FLAG_NOMERGES, &(q)->queue_flags) #define blk_queue_noxmerges(q) \ test_bit(QUEUE_FLAG_NOXMERGES, &(q)->queue_flags) -#define blk_queue_nonrot(q) ((q)->limits.features & BLK_FEAT_ROTATIONAL) +#define blk_queue_nonrot(q) (!((q)->limits.features & BLK_FEAT_ROTATIONAL)) #define blk_queue_io_stat(q) ((q)->limits.features & BLK_FEAT_IO_STAT) #define blk_queue_zone_resetall(q) \ ((q)->limits.features & BLK_FEAT_ZONE_RESETALL)
Take care of the inverse polarity of the BLK_FEAT_ROTATIONAL flag vs the old nonrot helper. Fixes: bd4a633b6f7c ("block: move the nonrot flag to queue_limits") Reported-by: kernel test robot <oliver.sang@intel.com> Reported-by: Keith Busch <kbusch@kernel.org> Signed-off-by: Christoph Hellwig <hch@lst.de> --- include/linux/blkdev.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)