diff mbox series

rust: block: fix generated bindings after refactoring of features

Message ID 20240628091152.2185241-1-nmi@metaspace.dk (mailing list archive)
State New
Headers show
Series rust: block: fix generated bindings after refactoring of features | expand

Commit Message

Andreas Hindborg June 28, 2024, 9:11 a.m. UTC 
From: Andreas Hindborg <a.hindborg@samsung.com>

Block device features and flags were refactored from `enum` to `#define`.
This broke Rust binding generation. This patch fixes the binding
generation.

Fixes: fcf865e357f8 ("block: convert features and flags to __bitwise types")
Signed-off-by: Andreas Hindborg <a.hindborg@samsung.com>
---
 rust/bindings/bindings_helper.h | 2 ++
 1 file changed, 2 insertions(+)


base-commit: 9c6e1f8702d51f233402d1aac96cdde8c6bf2877

Comments

Miguel Ojeda June 28, 2024, 10:48 a.m. UTC | #1 
On Fri, Jun 28, 2024 at 11:12 AM Andreas Hindborg <nmi@metaspace.dk> wrote:
>
> From: Andreas Hindborg <a.hindborg@samsung.com>
>
> Block device features and flags were refactored from `enum` to `#define`.
> This broke Rust binding generation. This patch fixes the binding
> generation.
>
> Fixes: fcf865e357f8 ("block: convert features and flags to __bitwise types")
> Signed-off-by: Andreas Hindborg <a.hindborg@samsung.com>

I saw this failure too in next-20240627, so:

Acked-by: Miguel Ojeda <ojeda@kernel.org>

Thanks!

Cheers,
Miguel
Jens Axboe June 28, 2024, 8:36 p.m. UTC | #2 
On Fri, 28 Jun 2024 11:11:52 +0200, Andreas Hindborg wrote:
> Block device features and flags were refactored from `enum` to `#define`.
> This broke Rust binding generation. This patch fixes the binding
> generation.
> 
> 

Applied, thanks!

[1/1] rust: block: fix generated bindings after refactoring of features
      commit: 5b026e34120766408e76ba19a0e33a9dc996f9f0

Best regards,
diff mbox series

Patch

diff --git a/rust/bindings/bindings_helper.h b/rust/bindings/bindings_helper.h
index 84f601d7068e..6deee85a29c8 100644
--- a/rust/bindings/bindings_helper.h
+++ b/rust/bindings/bindings_helper.h
@@ -9,6 +9,7 @@ 
 #include <kunit/test.h>
 #include <linux/blk_types.h>
 #include <linux/blk-mq.h>
+#include <linux/blkdev.h>
 #include <linux/errname.h>
 #include <linux/ethtool.h>
 #include <linux/jiffies.h>
@@ -28,3 +29,4 @@  const gfp_t RUST_CONST_HELPER_GFP_KERNEL = GFP_KERNEL;
 const gfp_t RUST_CONST_HELPER_GFP_KERNEL_ACCOUNT = GFP_KERNEL_ACCOUNT;
 const gfp_t RUST_CONST_HELPER_GFP_NOWAIT = GFP_NOWAIT;
 const gfp_t RUST_CONST_HELPER___GFP_ZERO = __GFP_ZERO;
+const blk_features_t RUST_CONST_HELPER_BLK_FEAT_ROTATIONAL = BLK_FEAT_ROTATIONAL;