| Message ID | 20240702073234.206458-1-dlemoal@kernel.org (mailing list archive) |
|---|---|
| State | New |
| Headers | show |
| Series | null_blk: Fix description of the fua parameter | expand |
On Tue, Jul 02, 2024 at 04:32:34PM +0900, Damien Le Moal wrote: > The description of the fua module parameter is defined using > MODULE_PARM_DESC() with the first argument passed being "zoned". That is > the wrong name, obviously. Fix that by using the correct "fua" parameter > name so that "modinfo null_blk" displays correct information. Looks good: Reviewed-by: Christoph Hellwig <hch@lst.de>
On 7/2/24 00:32, Damien Le Moal wrote: > The description of the fua module parameter is defined using > MODULE_PARM_DESC() with the first argument passed being "zoned". That is > the wrong name, obviously. Fix that by using the correct "fua" parameter > name so that "modinfo null_blk" displays correct information. > > Fixes: f4f84586c8b9 ("null_blk: Introduce fua attribute") > Cc: stable@vger.kernel.org > Signed-off-by: Damien Le Moal <dlemoal@kernel.org> > --- > Looks good. Reviewed-by: Chaitanya Kulkarni <kch@nvidia.com> -ck
On Tue, 02 Jul 2024 16:32:34 +0900, Damien Le Moal wrote: > The description of the fua module parameter is defined using > MODULE_PARM_DESC() with the first argument passed being "zoned". That is > the wrong name, obviously. Fix that by using the correct "fua" parameter > name so that "modinfo null_blk" displays correct information. > > Applied, thanks! [1/1] null_blk: Fix description of the fua parameter commit: 1c0b3fca381bf879e2168b362692f83808677f95 Best regards,
在 2024/7/2 15:32, Damien Le Moal 写道: > The description of the fua module parameter is defined using > MODULE_PARM_DESC() with the first argument passed being "zoned". That is > the wrong name, obviously. Fix that by using the correct "fua" parameter > name so that "modinfo null_blk" displays correct information. > > Fixes: f4f84586c8b9 ("null_blk: Introduce fua attribute") > Cc: stable@vger.kernel.org > Signed-off-by: Damien Le Moal <dlemoal@kernel.org> > --- > drivers/block/null_blk/main.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/block/null_blk/main.c b/drivers/block/null_blk/main.c > index 83a4ebe4763a..5de9ca4eceb4 100644 > --- a/drivers/block/null_blk/main.c > +++ b/drivers/block/null_blk/main.c > @@ -227,7 +227,7 @@ MODULE_PARM_DESC(mbps, "Cache size in MiB for memory-backed device. Default: 0 ( > > static bool g_fua = true; > module_param_named(fua, g_fua, bool, 0444); > -MODULE_PARM_DESC(zoned, "Enable/disable FUA support when cache_size is used. Default: true"); > +MODULE_PARM_DESC(fua, "Enable/disable FUA support when cache_size is used. Default: true"); Reviewed-by: Zhu Yanjun <yanjun.zhu@linux.dev> Zhu Yanjun > > static unsigned int g_mbps; > module_param_named(mbps, g_mbps, uint, 0444);
diff --git a/drivers/block/null_blk/main.c b/drivers/block/null_blk/main.c index 83a4ebe4763a..5de9ca4eceb4 100644 --- a/drivers/block/null_blk/main.c +++ b/drivers/block/null_blk/main.c @@ -227,7 +227,7 @@ MODULE_PARM_DESC(mbps, "Cache size in MiB for memory-backed device. Default: 0 ( static bool g_fua = true; module_param_named(fua, g_fua, bool, 0444); -MODULE_PARM_DESC(zoned, "Enable/disable FUA support when cache_size is used. Default: true"); +MODULE_PARM_DESC(fua, "Enable/disable FUA support when cache_size is used. Default: true"); static unsigned int g_mbps; module_param_named(mbps, g_mbps, uint, 0444);
The description of the fua module parameter is defined using MODULE_PARM_DESC() with the first argument passed being "zoned". That is the wrong name, obviously. Fix that by using the correct "fua" parameter name so that "modinfo null_blk" displays correct information. Fixes: f4f84586c8b9 ("null_blk: Introduce fua attribute") Cc: stable@vger.kernel.org Signed-off-by: Damien Le Moal <dlemoal@kernel.org> --- drivers/block/null_blk/main.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)