| Message ID | 20240709045432.8688-1-kch@nvidia.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | block: fix get_max_segment_size() warning | expand |
On 7/9/24 13:54, Chaitanya Kulkarni wrote: > Correct the parameter name in the comment of get_max_segment_size() > to fix following warning:- > > block/blk-merge.c:220: warning: Function parameter or struct member 'len' not described in 'get_max_segment_size' > block/blk-merge.c:220: warning: Excess function parameter 'max_len' description in 'get_max_segment_size' > > Signed-off-by: Chaitanya Kulkarni <kch@nvidia.com> Reviewed-by: Damien Le Moal <dlemoal@kernel.org>
On Mon, 08 Jul 2024 21:54:32 -0700, Chaitanya Kulkarni wrote: > Correct the parameter name in the comment of get_max_segment_size() > to fix following warning:- > > block/blk-merge.c:220: warning: Function parameter or struct member 'len' not described in 'get_max_segment_size' > block/blk-merge.c:220: warning: Excess function parameter 'max_len' description in 'get_max_segment_size' > > > [...] Applied, thanks! [1/1] block: fix get_max_segment_size() warning commit: 0ffc46eb1b6d0b9dd07e4f2b1019edd4fe678b9e Best regards,
Looks good:
Reviewed-by: Christoph Hellwig <hch@lst.de>
diff --git a/block/blk-merge.c b/block/blk-merge.c index 94502261e24a..668b784bc246 100644 --- a/block/blk-merge.c +++ b/block/blk-merge.c @@ -210,7 +210,7 @@ static inline unsigned get_max_io_size(struct bio *bio, * get_max_segment_size() - maximum number of bytes to add as a single segment * @lim: Request queue limits. * @paddr: address of the range to add - * @max_len: maximum length available to add at @paddr + * @len: maximum length available to add at @paddr * * Returns the maximum number of bytes of the range starting at @paddr that can * be added to a single segment.
Correct the parameter name in the comment of get_max_segment_size() to fix following warning:- block/blk-merge.c:220: warning: Function parameter or struct member 'len' not described in 'get_max_segment_size' block/blk-merge.c:220: warning: Excess function parameter 'max_len' description in 'get_max_segment_size' Signed-off-by: Chaitanya Kulkarni <kch@nvidia.com> --- block/blk-merge.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)