| Message ID | 20240826042835.1911916-1-11162571@vivo.com (mailing list archive) |
|---|---|
| State | New |
| Headers | show |
| Series | [v5] pktcdvd:Remove unnecessary debugfs_create_dir() error check in pkt_debugfs_dev_new() | expand |
On 8/26/24 1:28 PM, Yang Ruibin wrote: > This patch removes the debugfs_create_dir() error checking in > pkt_debugfs_dev_new(). Because the debugfs_create_dir() is developed > in a way that the caller can safely handle the errors that > occur during the creation of DebugFS nodes. Missing sapce after the prefix in the patch title: "pktcdvd: Remove..." And the commit message explanation makes no sense. You likely wanted to say that *debugfs_create_file()* accepts a parent dentry that is an error pointer and returns an error in such case, right ? Also, there is no need for phrasing like "This patch removes...". We know it is a patch, we are looking at it :) So simply be assertive: "Remove ..." > > Signed-off-by: Yang Ruibin <11162571@vivo.com> > --- > Changes v5: > -Changed the subject line > -Fixes information has been deleted > --- > drivers/block/pktcdvd.c | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/drivers/block/pktcdvd.c b/drivers/block/pktcdvd.c > index 7cece5884b9c..3edb37a41312 100644 > --- a/drivers/block/pktcdvd.c > +++ b/drivers/block/pktcdvd.c > @@ -498,8 +498,6 @@ static void pkt_debugfs_dev_new(struct pktcdvd_device *pd) > if (!pkt_debugfs_root) > return; > pd->dfs_d_root = debugfs_create_dir(pd->disk->disk_name, pkt_debugfs_root); > - if (!pd->dfs_d_root) > - return; > > pd->dfs_f_info = debugfs_create_file("info", 0444, pd->dfs_d_root, > pd, &pkt_seq_fops);
diff --git a/drivers/block/pktcdvd.c b/drivers/block/pktcdvd.c index 7cece5884b9c..3edb37a41312 100644 --- a/drivers/block/pktcdvd.c +++ b/drivers/block/pktcdvd.c @@ -498,8 +498,6 @@ static void pkt_debugfs_dev_new(struct pktcdvd_device *pd) if (!pkt_debugfs_root) return; pd->dfs_d_root = debugfs_create_dir(pd->disk->disk_name, pkt_debugfs_root); - if (!pd->dfs_d_root) - return; pd->dfs_f_info = debugfs_create_file("info", 0444, pd->dfs_d_root, pd, &pkt_seq_fops);
This patch removes the debugfs_create_dir() error checking in pkt_debugfs_dev_new(). Because the debugfs_create_dir() is developed in a way that the caller can safely handle the errors that occur during the creation of DebugFS nodes. Signed-off-by: Yang Ruibin <11162571@vivo.com> --- Changes v5: -Changed the subject line -Fixes information has been deleted --- drivers/block/pktcdvd.c | 2 -- 1 file changed, 2 deletions(-)