| Message ID | 20241216210244.2687662-5-bvanassche@acm.org (mailing list archive) |
|---|---|
| State | New |
| Headers | show |
| Series | Minor improvements for the zoned block storage code | expand |
Looks good:
Reviewed-by: Christoph Hellwig <hch@lst.de>
On 2024/12/16 13:02, Bart Van Assche wrote: > For the blk_queue_exit() calls, document where the corresponding code can > be found that increases q->q_usage_counter. > > Cc: Damien Le Moal <dlemoal@kernel.org> > Cc: Christoph Hellwig <hch@lst.de> > Signed-off-by: Bart Van Assche <bvanassche@acm.org> Reviewed-by: Damien Le Moal <dlemoal@kernel.org>
diff --git a/block/blk-zoned.c b/block/blk-zoned.c index ca44b2d6727c..0f7666441fe1 100644 --- a/block/blk-zoned.c +++ b/block/blk-zoned.c @@ -583,6 +583,7 @@ static inline void blk_zone_wplug_bio_io_error(struct blk_zone_wplug *zwplug, bio_clear_flag(bio, BIO_ZONE_WRITE_PLUGGING); bio_io_error(bio); disk_put_zone_wplug(zwplug); + /* Drop the reference taken by disk_zone_wplug_add_bio(() */ blk_queue_exit(q); } @@ -894,10 +895,7 @@ void blk_zone_write_plug_init_request(struct request *req) break; } - /* - * Drop the extra reference on the queue usage we got when - * plugging the BIO and advance the write pointer offset. - */ + /* Drop the reference taken by disk_zone_wplug_add_bio(). */ blk_queue_exit(q); zwplug->wp_offset += bio_sectors(bio);
For the blk_queue_exit() calls, document where the corresponding code can be found that increases q->q_usage_counter. Cc: Damien Le Moal <dlemoal@kernel.org> Cc: Christoph Hellwig <hch@lst.de> Signed-off-by: Bart Van Assche <bvanassche@acm.org> --- block/blk-zoned.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-)