diff mbox series

blk-cgroup: fix kernel-doc warnings in header file

Message ID 20250111062736.910383-1-rdunlap@infradead.org (mailing list archive)
State New
Headers show
Series blk-cgroup: fix kernel-doc warnings in header file | expand

Commit Message

Randy Dunlap Jan. 11, 2025, 6:27 a.m. UTC
Correct the function parameters and function names to eliminate
kernel-doc warnings:

blk-cgroup.h:238: warning: Function parameter or struct member 'bio' not described in 'bio_issue_as_root_blkg'
blk-cgroup.h:248: warning: bad line: 
blk-cgroup.h:279: warning: expecting prototype for blkg_to_pdata(). Prototype was for blkg_to_pd() instead
blk-cgroup.h:296: warning: expecting prototype for pdata_to_blkg(). Prototype was for pd_to_blkg() instead

Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
Cc: Tejun Heo <tj@kernel.org>
Cc: Josef Bacik <josef@toxicpanda.com>
Cc: Jens Axboe <axboe@kernel.dk>
Cc: cgroups@vger.kernel.org
---
 block/blk-cgroup.h |   10 ++++++----
 1 file changed, 6 insertions(+), 4 deletions(-)

Comments

Jens Axboe Jan. 13, 2025, 2:47 p.m. UTC | #1
On Fri, 10 Jan 2025 22:27:36 -0800, Randy Dunlap wrote:
> Correct the function parameters and function names to eliminate
> kernel-doc warnings:
> 
> blk-cgroup.h:238: warning: Function parameter or struct member 'bio' not described in 'bio_issue_as_root_blkg'
> blk-cgroup.h:248: warning: bad line:
> blk-cgroup.h:279: warning: expecting prototype for blkg_to_pdata(). Prototype was for blkg_to_pd() instead
> blk-cgroup.h:296: warning: expecting prototype for pdata_to_blkg(). Prototype was for pd_to_blkg() instead
> 
> [...]

Applied, thanks!

[1/1] blk-cgroup: fix kernel-doc warnings in header file
      commit: 4fa5c37012d71f6a39c4286ffabb9466f1728ba3

Best regards,
diff mbox series

Patch

--- linux-next-20250108.orig/block/blk-cgroup.h
+++ linux-next-20250108/block/blk-cgroup.h
@@ -225,7 +225,9 @@  void blkg_conf_exit(struct blkg_conf_ctx
 
 /**
  * bio_issue_as_root_blkg - see if this bio needs to be issued as root blkg
- * @return: true if this bio needs to be submitted with the root blkg context.
+ * @bio: the target &bio
+ *
+ * Return: true if this bio needs to be submitted with the root blkg context.
  *
  * In order to avoid priority inversions we sometimes need to issue a bio as if
  * it were attached to the root blkg, and then backcharge to the actual owning
@@ -245,7 +247,7 @@  static inline bool bio_issue_as_root_blk
  * @q: request_queue of interest
  *
  * Lookup blkg for the @blkcg - @q pair.
-
+ *
  * Must be called in a RCU critical section.
  */
 static inline struct blkcg_gq *blkg_lookup(struct blkcg *blkcg,
@@ -268,7 +270,7 @@  static inline struct blkcg_gq *blkg_look
 }
 
 /**
- * blkg_to_pdata - get policy private data
+ * blkg_to_pd - get policy private data
  * @blkg: blkg of interest
  * @pol: policy of interest
  *
@@ -287,7 +289,7 @@  static inline struct blkcg_policy_data *
 }
 
 /**
- * pdata_to_blkg - get blkg associated with policy private data
+ * pd_to_blkg - get blkg associated with policy private data
  * @pd: policy private data of interest
  *
  * @pd is policy private data.  Determine the blkg it's associated with.