| Message ID | 20250208035224.128454-1-kanie@linux.alibaba.com (mailing list archive) |
|---|---|
| State | New |
| Headers | show |
| Series | [RFC] block: print the real address of request in debugfs | expand |
Gently ping... Best Regards, Guixin Liu 在 2025/2/8 11:52, Guixin Liu 写道: > Since only root user can access debugfs, for easier issue > identification, use '%px' to print the request's real address in > debugfs. > > Signed-off-by: Guixin Liu <kanie@linux.alibaba.com> > --- > Hi, > I notice that block dont print the real address in > debugfs for a long time, I wonder what the community's > concerns are, thanks, so this is a RFC patch. > Best Regards, > Guixin Liu > > block/blk-mq-debugfs.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/block/blk-mq-debugfs.c b/block/blk-mq-debugfs.c > index adf5f0697b6b..c430d931512f 100644 > --- a/block/blk-mq-debugfs.c > +++ b/block/blk-mq-debugfs.c > @@ -265,7 +265,7 @@ int __blk_mq_debugfs_rq_show(struct seq_file *m, struct request *rq) > BUILD_BUG_ON(ARRAY_SIZE(cmd_flag_name) != __REQ_NR_BITS); > BUILD_BUG_ON(ARRAY_SIZE(rqf_name) != __RQF_BITS); > > - seq_printf(m, "%p {.op=", rq); > + seq_printf(m, "%px {.op=", rq); > if (strcmp(op_str, "UNKNOWN") == 0) > seq_printf(m, "%u", op); > else
Hi, 在 2025/02/12 17:55, Guixin Liu 写道: > Gently ping... > > Best Regards, > > Guixin Liu > > 在 2025/2/8 11:52, Guixin Liu 写道: >> Since only root user can access debugfs, for easier issue >> identification, use '%px' to print the request's real address in >> debugfs. I search and find out that %p is introduced in the first commit: 320ae51feed5 ("blk-mq: new multi-queue block IO queueing mechanism"). I think usually we should not print address by debugfs, and I don't see why this is needed here. For root user trying to debug, the tag information should be enough. Just wonder maybe we can just remove this. Thanks, Kuai >> >> Signed-off-by: Guixin Liu <kanie@linux.alibaba.com> >> --- >> Hi, >> I notice that block dont print the real address in >> debugfs for a long time, I wonder what the community's >> concerns are, thanks, so this is a RFC patch. >> Best Regards, >> Guixin Liu >> >> block/blk-mq-debugfs.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/block/blk-mq-debugfs.c b/block/blk-mq-debugfs.c >> index adf5f0697b6b..c430d931512f 100644 >> --- a/block/blk-mq-debugfs.c >> +++ b/block/blk-mq-debugfs.c >> @@ -265,7 +265,7 @@ int __blk_mq_debugfs_rq_show(struct seq_file *m, >> struct request *rq) >> BUILD_BUG_ON(ARRAY_SIZE(cmd_flag_name) != __REQ_NR_BITS); >> BUILD_BUG_ON(ARRAY_SIZE(rqf_name) != __RQF_BITS); >> - seq_printf(m, "%p {.op=", rq); >> + seq_printf(m, "%px {.op=", rq); >> if (strcmp(op_str, "UNKNOWN") == 0) >> seq_printf(m, "%u", op); >> else > > . >
diff --git a/block/blk-mq-debugfs.c b/block/blk-mq-debugfs.c index adf5f0697b6b..c430d931512f 100644 --- a/block/blk-mq-debugfs.c +++ b/block/blk-mq-debugfs.c @@ -265,7 +265,7 @@ int __blk_mq_debugfs_rq_show(struct seq_file *m, struct request *rq) BUILD_BUG_ON(ARRAY_SIZE(cmd_flag_name) != __REQ_NR_BITS); BUILD_BUG_ON(ARRAY_SIZE(rqf_name) != __RQF_BITS); - seq_printf(m, "%p {.op=", rq); + seq_printf(m, "%px {.op=", rq); if (strcmp(op_str, "UNKNOWN") == 0) seq_printf(m, "%u", op); else
Since only root user can access debugfs, for easier issue identification, use '%px' to print the request's real address in debugfs. Signed-off-by: Guixin Liu <kanie@linux.alibaba.com> --- Hi, I notice that block dont print the real address in debugfs for a long time, I wonder what the community's concerns are, thanks, so this is a RFC patch. Best Regards, Guixin Liu block/blk-mq-debugfs.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)