| Message ID | 20250213100611.209997-3-yizhou.tang@shopee.com (mailing list archive) |
|---|---|
| State | New |
| Headers | show |
| Series | Fix and cleanup some comments in blk-wbt | expand |
Hi, 在 2025/02/13 18:06, Tang Yizhou 写道: > From: Tang Yizhou <yizhou.tang@shopee.com> > > The original comment contains a grammatical error. Rewrite it into a more > easily understandable sentence. > > Signed-off-by: Tang Yizhou <yizhou.tang@shopee.com> > --- > block/blk-wbt.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > Personally, I don't think this patch is necessary, people can still understand with this error. I'm not expecting a seperate patch :( Thanks, Kuai > diff --git a/block/blk-wbt.c b/block/blk-wbt.c > index 8b73c0c11aec..f1754d07f7e0 100644 > --- a/block/blk-wbt.c > +++ b/block/blk-wbt.c > @@ -447,9 +447,9 @@ static void wb_timer_fn(struct blk_stat_callback *cb) > break; > case LAT_UNKNOWN_WRITES: > /* > - * We started a the center step, but don't have a valid > - * read/write sample, but we do have writes going on. > - * Allow step to go negative, to increase write perf. > + * We don't have a valid read/write sample, but we do have > + * writes going on. Allow step to go negative, to increase > + * write performance. > */ > scale_up(rwb); > break; >
On Thu, Feb 13, 2025 at 7:17 PM Yu Kuai <yukuai1@huaweicloud.com> wrote: > > Hi, > > 在 2025/02/13 18:06, Tang Yizhou 写道: > > From: Tang Yizhou <yizhou.tang@shopee.com> > > > > The original comment contains a grammatical error. Rewrite it into a more > > easily understandable sentence. > > > > Signed-off-by: Tang Yizhou <yizhou.tang@shopee.com> > > --- > > block/blk-wbt.c | 6 +++--- > > 1 file changed, 3 insertions(+), 3 deletions(-) > > > > Personally, I don't think this patch is necessary, people can still > understand with this error. I'm not expecting a seperate patch :( > > Thanks, > Kuai > Got it. Let's see if others have any suggestions. Thanks, Yi > > diff --git a/block/blk-wbt.c b/block/blk-wbt.c > > index 8b73c0c11aec..f1754d07f7e0 100644 > > --- a/block/blk-wbt.c > > +++ b/block/blk-wbt.c > > @@ -447,9 +447,9 @@ static void wb_timer_fn(struct blk_stat_callback *cb) > > break; > > case LAT_UNKNOWN_WRITES: > > /* > > - * We started a the center step, but don't have a valid > > - * read/write sample, but we do have writes going on. > > - * Allow step to go negative, to increase write perf. > > + * We don't have a valid read/write sample, but we do have > > + * writes going on. Allow step to go negative, to increase > > + * write performance. > > */ > > scale_up(rwb); > > break; > > >
diff --git a/block/blk-wbt.c b/block/blk-wbt.c index 8b73c0c11aec..f1754d07f7e0 100644 --- a/block/blk-wbt.c +++ b/block/blk-wbt.c @@ -447,9 +447,9 @@ static void wb_timer_fn(struct blk_stat_callback *cb) break; case LAT_UNKNOWN_WRITES: /* - * We started a the center step, but don't have a valid - * read/write sample, but we do have writes going on. - * Allow step to go negative, to increase write perf. + * We don't have a valid read/write sample, but we do have + * writes going on. Allow step to go negative, to increase + * write performance. */ scale_up(rwb); break;