| Message ID | 20250319021343.3976476-1-ming.lei@redhat.com (mailing list archive) |
|---|---|
| State | New |
| Headers | show |
| Series | block: don't define __blk_mq_end_request() as inline | expand |
| Context | Check | Description |
|---|---|---|
| shin/vmtest-linus-master-PR | success | PR summary |
| shin/vmtest-linus-master-VM_Test-1 | success | Logs for build-kernel |
| shin/vmtest-linus-master-VM_Test-0 | success | Logs for build-kernel |
On 3/18/25 8:13 PM, Ming Lei wrote: > It doesn't make sense to define one global symbol as inline, also this > way cause __blk_mq_end_request become not traceable. It does for the local scope though, it'll force it inline for blk_mq_end_request(), for example.
diff --git a/block/blk-mq.c b/block/blk-mq.c index ae8494d88897..1301965dae71 100644 --- a/block/blk-mq.c +++ b/block/blk-mq.c @@ -1123,7 +1123,7 @@ static inline void __blk_mq_end_request_acct(struct request *rq, u64 now) blk_account_io_done(rq, now); } -inline void __blk_mq_end_request(struct request *rq, blk_status_t error) +void __blk_mq_end_request(struct request *rq, blk_status_t error) { if (blk_mq_need_time_stamp(rq)) __blk_mq_end_request_acct(rq, blk_time_get_ns());
It doesn't make sense to define one global symbol as inline, also this way cause __blk_mq_end_request become not traceable. Fix it by removing the 'inline' annotation. Signed-off-by: Ming Lei <ming.lei@redhat.com> --- block/blk-mq.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)