| Message ID | 20250408104209.1852036-4-john.g.garry@oracle.com (mailing list archive) |
|---|---|
| State | New |
| Headers | show |
| Series | large atomic writes for xfs | expand |
On Tue, Apr 08, 2025 at 10:42:00AM +0000, John Garry wrote: > In future we will want to be able to check if specifically HW offload-based > atomic writes are possible, so rename xfs_inode_can_atomicwrite() -> > xfs_inode_can_hw_atomicwrite(). > > Signed-off-by: John Garry <john.g.garry@oracle.com> Looks ok, Reviewed-by: "Darrick J. Wong" <djwong@kernel.org> --D > --- > fs/xfs/xfs_file.c | 2 +- > fs/xfs/xfs_inode.h | 2 +- > fs/xfs/xfs_iops.c | 2 +- > 3 files changed, 3 insertions(+), 3 deletions(-) > > diff --git a/fs/xfs/xfs_file.c b/fs/xfs/xfs_file.c > index 84f08c976ac4..653e42ccc0c3 100644 > --- a/fs/xfs/xfs_file.c > +++ b/fs/xfs/xfs_file.c > @@ -1488,7 +1488,7 @@ xfs_file_open( > if (xfs_is_shutdown(XFS_M(inode->i_sb))) > return -EIO; > file->f_mode |= FMODE_NOWAIT | FMODE_CAN_ODIRECT; > - if (xfs_inode_can_atomicwrite(XFS_I(inode))) > + if (xfs_inode_can_hw_atomicwrite(XFS_I(inode))) > file->f_mode |= FMODE_CAN_ATOMIC_WRITE; > return generic_file_open(inode, file); > } > diff --git a/fs/xfs/xfs_inode.h b/fs/xfs/xfs_inode.h > index eae0159983ca..cff643cd03fc 100644 > --- a/fs/xfs/xfs_inode.h > +++ b/fs/xfs/xfs_inode.h > @@ -357,7 +357,7 @@ static inline bool xfs_inode_has_bigrtalloc(const struct xfs_inode *ip) > (ip)->i_mount->m_rtdev_targp : (ip)->i_mount->m_ddev_targp) > > static inline bool > -xfs_inode_can_atomicwrite( > +xfs_inode_can_hw_atomicwrite( > struct xfs_inode *ip) > { > struct xfs_mount *mp = ip->i_mount; > diff --git a/fs/xfs/xfs_iops.c b/fs/xfs/xfs_iops.c > index f0e5d83195df..d324044a2225 100644 > --- a/fs/xfs/xfs_iops.c > +++ b/fs/xfs/xfs_iops.c > @@ -608,7 +608,7 @@ xfs_report_atomic_write( > { > unsigned int unit_min = 0, unit_max = 0; > > - if (xfs_inode_can_atomicwrite(ip)) > + if (xfs_inode_can_hw_atomicwrite(ip)) > unit_min = unit_max = ip->i_mount->m_sb.sb_blocksize; > generic_fill_statx_atomic_writes(stat, unit_min, unit_max, 0); > } > -- > 2.31.1 > >
Looks good:
Reviewed-by: Christoph Hellwig <hch@lst.de>
diff --git a/fs/xfs/xfs_file.c b/fs/xfs/xfs_file.c index 84f08c976ac4..653e42ccc0c3 100644 --- a/fs/xfs/xfs_file.c +++ b/fs/xfs/xfs_file.c @@ -1488,7 +1488,7 @@ xfs_file_open( if (xfs_is_shutdown(XFS_M(inode->i_sb))) return -EIO; file->f_mode |= FMODE_NOWAIT | FMODE_CAN_ODIRECT; - if (xfs_inode_can_atomicwrite(XFS_I(inode))) + if (xfs_inode_can_hw_atomicwrite(XFS_I(inode))) file->f_mode |= FMODE_CAN_ATOMIC_WRITE; return generic_file_open(inode, file); } diff --git a/fs/xfs/xfs_inode.h b/fs/xfs/xfs_inode.h index eae0159983ca..cff643cd03fc 100644 --- a/fs/xfs/xfs_inode.h +++ b/fs/xfs/xfs_inode.h @@ -357,7 +357,7 @@ static inline bool xfs_inode_has_bigrtalloc(const struct xfs_inode *ip) (ip)->i_mount->m_rtdev_targp : (ip)->i_mount->m_ddev_targp) static inline bool -xfs_inode_can_atomicwrite( +xfs_inode_can_hw_atomicwrite( struct xfs_inode *ip) { struct xfs_mount *mp = ip->i_mount; diff --git a/fs/xfs/xfs_iops.c b/fs/xfs/xfs_iops.c index f0e5d83195df..d324044a2225 100644 --- a/fs/xfs/xfs_iops.c +++ b/fs/xfs/xfs_iops.c @@ -608,7 +608,7 @@ xfs_report_atomic_write( { unsigned int unit_min = 0, unit_max = 0; - if (xfs_inode_can_atomicwrite(ip)) + if (xfs_inode_can_hw_atomicwrite(ip)) unit_min = unit_max = ip->i_mount->m_sb.sb_blocksize; generic_fill_statx_atomic_writes(stat, unit_min, unit_max, 0); }
In future we will want to be able to check if specifically HW offload-based atomic writes are possible, so rename xfs_inode_can_atomicwrite() -> xfs_inode_can_hw_atomicwrite(). Signed-off-by: John Garry <john.g.garry@oracle.com> --- fs/xfs/xfs_file.c | 2 +- fs/xfs/xfs_inode.h | 2 +- fs/xfs/xfs_iops.c | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-)