From patchwork Thu Oct 27 15:56:17 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Yasuaki Ishimatsu X-Patchwork-Id: 9399813 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id C67E9600BA for ; Thu, 27 Oct 2016 15:56:33 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id B39792A354 for ; Thu, 27 Oct 2016 15:56:33 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id A5E6C2A353; Thu, 27 Oct 2016 15:56:33 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.3 required=2.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED, FREEMAIL_FROM, RCVD_IN_DNSWL_HI, RCVD_IN_SORBS_SPAM, T_DKIM_INVALID autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 37D9C2A353 for ; Thu, 27 Oct 2016 15:56:33 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S935797AbcJ0P4Q (ORCPT ); Thu, 27 Oct 2016 11:56:16 -0400 Received: from mail-qt0-f194.google.com ([209.85.216.194]:34702 "EHLO mail-qt0-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933914AbcJ0P4P (ORCPT ); Thu, 27 Oct 2016 11:56:15 -0400 Received: by mail-qt0-f194.google.com with SMTP id r21so1428897qtr.1; Thu, 27 Oct 2016 08:56:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=subject:to:from:cc:message-id:date:user-agent:mime-version :content-transfer-encoding; bh=eROdbEpsfXw+C2UzQQ6KNXk4Q3jtP4rNWcNFNHCiVHQ=; b=QwUN4eYFxEKzqklX3Wxy3AZByGOnd9gXFC/aRZzTwZYALdtrihfUAMcQAC7gbkn4v0 XdTTpbD9Ctc0NlIfkNwuESojmm/08EgUyXhinEECn/NF9Yky90YwVFnheHA/4PSib0wL 0ODCgIC3MePCRT+ZUSYNvAm6nm/KrjzjXjoRXDqY0FyuJt1tVCdljVusDu0gBhYzWlPz iXe14VZyKsjnIQwRxGVDZZNUwrWWZXFz3UiiW8yQC7OZGO6m395O6BcAz/MAtemi21kK FptaB8cRAQGumBYs3oQAWTrIDeKHliFEAAUL4JcHBEZr2yYKrWhrpkcshKgph4oKiFNU QPgg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:subject:to:from:cc:message-id:date:user-agent :mime-version:content-transfer-encoding; bh=eROdbEpsfXw+C2UzQQ6KNXk4Q3jtP4rNWcNFNHCiVHQ=; b=Z6yqMocgbha1GjmeCb9/xxIo42K6cZNADAjDvHuKn0P3dPvsOvrFHdCft+QqvitjFO v+SEHE67BwUwZ8+MA8NCauaU/pSIj0pax7GRd2v6S6Wf2p3ufAc6cRdXFmMLHBKZXTG1 pm0iUPkHZ8XTn69hsf0xtrvniHNH5sxAP07+BfmGUF5J98ibHAyXLVjDn1iETXCYvIcm 7nIHKeeb8f5NPc6/b6IfWEgMXYRHO4tsWX1+EXr4r1SfJg9y5bO8F+wrNWuESd2Y7sX0 creOuTn4rbn263ueKm43HW6aMZnEoOH6CycpUWnyvpcpYm1sGAlU2yN+6kzZ+k4AAoJW xVBw== X-Gm-Message-State: ABUngve3T0xy/PPe6rmBxEoQ29bfN7bgWKyAAcclsmEfAgqbSk0cngFziZuqMSeFMOxQSA== X-Received: by 10.237.51.167 with SMTP id v36mr3074649qtd.46.1477583774294; Thu, 27 Oct 2016 08:56:14 -0700 (PDT) Received: from [10.18.17.63] (nat-pool-bos-t.redhat.com. [66.187.233.206]) by smtp.gmail.com with ESMTPSA id k44sm3929230qtk.3.2016.10.27.08.56.13 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 27 Oct 2016 08:56:13 -0700 (PDT) Subject: [PATCH] null_blk: Add notes to use LightNVM To: linux-kernel@vger.kernel.org, linux-block@vger.kernel.org From: Yasuaki Ishimatsu Cc: axboe@kernel.dk Message-ID: <37a5a6a3-cd8b-db98-b4f3-7bd66a5bf4d8@gmail.com> Date: Thu, 27 Oct 2016 11:56:17 -0400 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.3.0 MIME-Version: 1.0 Sender: linux-block-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-block@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP If CONFIG_NVM is disabled, loading null_block module with use_lightnvm=1 fails. But there are no messages and documents related to the failure. So the patch adds the notes to use LightNVM. Signed-off-by: Yasuaki Ishimatsu Cc: Jens Axboe --- Documentation/block/null_blk.txt | 2 +- drivers/block/null_blk.c | 1 + 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/Documentation/block/null_blk.txt b/Documentation/block/null_blk.txt index d8880ca..0365a26 100644 --- a/Documentation/block/null_blk.txt +++ b/Documentation/block/null_blk.txt @@ -72,4 +72,4 @@ use_per_node_hctx=[0/1]: Default: 0 queue for each CPU node in the system. use_lightnvm=[0/1]: Default: 0 - Register device with LightNVM. Requires blk-mq to be used. + Register device with LightNVM. Requires blk-mq and CONFIG_NVM=y to be used. diff --git a/drivers/block/null_blk.c b/drivers/block/null_blk.c index ba6f4a2e..4943ee2 100644 --- a/drivers/block/null_blk.c +++ b/drivers/block/null_blk.c @@ -577,6 +577,7 @@ static void null_nvm_unregister(struct nullb *nullb) #else static int null_nvm_register(struct nullb *nullb) { + pr_err("null_blk: CONFIG_NVM needs to be enabled for LightNVM\n"); return -EINVAL; } static void null_nvm_unregister(struct nullb *nullb) {}