From patchwork Thu Dec 10 14:17:16 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Geliang Tang X-Patchwork-Id: 7819111 X-Patchwork-Delegate: axboe@kernel.dk Return-Path: X-Original-To: patchwork-linux-block@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork2.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.136]) by patchwork2.web.kernel.org (Postfix) with ESMTP id E0B82BEEE1 for ; Thu, 10 Dec 2015 14:19:33 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 1E33320218 for ; Thu, 10 Dec 2015 14:19:33 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 6489920375 for ; Thu, 10 Dec 2015 14:19:28 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752521AbbLJOT1 (ORCPT ); Thu, 10 Dec 2015 09:19:27 -0500 Received: from m50-134.163.com ([123.125.50.134]:48046 "EHLO m50-134.163.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752324AbbLJOT0 (ORCPT ); Thu, 10 Dec 2015 09:19:26 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=163.com; s=s110527; h=From:Subject:Date:Message-Id; bh=eFs/qHm56Ug9EOQ9/e nPu/1bmJAx5KAxmVfSgBXv1Zo=; b=KLqBYQe3uQI8yezSnzslTpxbkppPoyWVct Gr3CN4n5EAXgDvuRjO5GK+KB76Psy6LCouAC4xKnPJa6SEsSfBtSQS671CP/cYx3 uM6NFdOdfa+qvvIvy16RE1e40t9KI2RMNuMdGYjxjjz28R1k3dYlGQt7OT2JuwFL g+dke67Xw= Received: from localhost (unknown [116.77.128.176]) by smtp4 (Coremail) with SMTP id DtGowEB5Zm92iWlWRbc_AA--.18S3; Thu, 10 Dec 2015 22:17:27 +0800 (CST) From: Geliang Tang To: Josh Poimboeuf , Seth Jennings , Jiri Kosina , Vojtech Pavlik Cc: Geliang Tang , Pablo Neira Ayuso , Patrick McHardy , Jozsef Kadlecsik , "David S. Miller" , Jens Axboe , "Paul E. McKenney" , Jan Kara , Josef Bacik , Josh Triplett , live-patching@vger.kernel.org, netfilter-devel@vger.kernel.org, coreteam@netfilter.org, netdev@vger.kernel.org, linux-block@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH 2/4] livepatch: use list_is_first() Date: Thu, 10 Dec 2015 22:17:16 +0800 Message-Id: <394e9e5ece944969fe1ff4f37c9a73bf5543265e.1449755818.git.geliangtang@163.com> X-Mailer: git-send-email 2.5.0 In-Reply-To: <305feb971ae11e192f35f25d66bb7b2e28e06c39.1449755818.git.geliangtang@163.com> References: <305feb971ae11e192f35f25d66bb7b2e28e06c39.1449755818.git.geliangtang@163.com> In-Reply-To: <305feb971ae11e192f35f25d66bb7b2e28e06c39.1449755818.git.geliangtang@163.com> References: <305feb971ae11e192f35f25d66bb7b2e28e06c39.1449755818.git.geliangtang@163.com> X-CM-TRANSID: DtGowEB5Zm92iWlWRbc_AA--.18S3 X-Coremail-Antispam: 1Uf129KBjvdXoWrtw45JFW3Gr13JrWkCrWkXrb_yoW3JFc_GF yUWrZ2kr10qan7A3Z5Kan2gr13Kry8ZanYvw4Sq3y5JFy5tr1Yq3y5J3ZxGr95WrZ2vF98 AF4kZrsrua12yjkaLaAFLSUrUUUUUb8apTn2vfkv8UJUUUU8Yxn0WfASr-VFAUDa7-sFnT 9fnUUvcSsGvfC2KfnxnUUI43ZEXa7IUjPxhtUUUUU== X-Originating-IP: [116.77.128.176] X-CM-SenderInfo: 5jhoxtpqjwt0rj6rljoofrz/xtbByhfMmVO+gc9-WgAAsO Sender: linux-block-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-block@vger.kernel.org X-Spam-Status: No, score=-6.8 required=5.0 tests=BAYES_00,DKIM_SIGNED, FREEMAIL_FROM,RCVD_IN_DNSWL_HI,T_DKIM_INVALID,T_RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=ham version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP For better readability, use list_is_first() instead of open-coded. Signed-off-by: Geliang Tang --- kernel/livepatch/core.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/kernel/livepatch/core.c b/kernel/livepatch/core.c index bc2c85c..be64106 100644 --- a/kernel/livepatch/core.c +++ b/kernel/livepatch/core.c @@ -479,7 +479,7 @@ static int __klp_enable_patch(struct klp_patch *patch) return -EINVAL; /* enforce stacking: only the first disabled patch can be enabled */ - if (patch->list.prev != &klp_patches && + if (!list_is_first(&patch->list, &klp_patches) && list_prev_entry(patch, list)->state == KLP_DISABLED) return -EBUSY;