From patchwork Thu Dec 10 14:20:00 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Geliang Tang X-Patchwork-Id: 7819171 X-Patchwork-Delegate: axboe@kernel.dk Return-Path: X-Original-To: patchwork-linux-block@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork2.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.136]) by patchwork2.web.kernel.org (Postfix) with ESMTP id B7EA0BEEE1 for ; Thu, 10 Dec 2015 14:23:09 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 49CF5202A1 for ; Thu, 10 Dec 2015 14:23:05 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 6EB842025B for ; Thu, 10 Dec 2015 14:23:04 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752611AbbLJOXE (ORCPT ); Thu, 10 Dec 2015 09:23:04 -0500 Received: from m50-134.163.com ([123.125.50.134]:39084 "EHLO m50-134.163.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752324AbbLJOXB (ORCPT ); Thu, 10 Dec 2015 09:23:01 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=163.com; s=s110527; h=From:Subject:Date:Message-Id; bh=xdK99iP3MSRBzdV/Ce CLJXq7BUPFYqw0Kp5Ga0WW80o=; b=mn++UfTwIWS+RQbxshVAG7L0IPgsTG9zqN hMdebsWkD/kIPBmS0McFfr4VtcVC4QSKxIkLWJhTe4RDKghwUaG0MAMO8o8UzOe7 n11zKbhco5sDN/g5Ui7ZUsV4z6Sx5Amh2jU/MRKe+eie/VztPh/nKg0PDLSXhavt XO9+0nbVo= Received: from localhost (unknown [116.77.128.176]) by smtp4 (Coremail) with SMTP id DtGowECZtmITimlWy_E_AA--.38S3; Thu, 10 Dec 2015 22:20:04 +0800 (CST) From: Geliang Tang To: Jens Axboe Cc: Geliang Tang , "Paul E. McKenney" , Jan Kara , Josef Bacik , Josh Triplett , Josh Poimboeuf , Seth Jennings , Jiri Kosina , Vojtech Pavlik , Pablo Neira Ayuso , Patrick McHardy , Jozsef Kadlecsik , "David S. Miller" , live-patching@vger.kernel.org, netfilter-devel@vger.kernel.org, coreteam@netfilter.org, netdev@vger.kernel.org, linux-block@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH 4/4] elevator: use list_is_{first,last} Date: Thu, 10 Dec 2015 22:20:00 +0800 Message-Id: <4f2d53c2ddbc9c0d4b00b4db1bd797b53faf8c2d.1449755818.git.geliangtang@163.com> X-Mailer: git-send-email 2.5.0 In-Reply-To: References: <305feb971ae11e192f35f25d66bb7b2e28e06c39.1449755818.git.geliangtang@163.com> <394e9e5ece944969fe1ff4f37c9a73bf5543265e.1449755818.git.geliangtang@163.com> X-CM-TRANSID: DtGowECZtmITimlWy_E_AA--.38S3 X-Coremail-Antispam: 1Uf129KBjvdXoWrtr1kKF4fJF47Aw15Kr4Uurg_yoWDGFb_C3 y2kr97tr4kGr4xZr4xCF1Sk3WxZ3WfJF1DJFW3KrWDW3W5GF4ayr9xJanxGFZxWrWfKFyf Aw18uay3GrnrKjkaLaAFLSUrUUUUjb8apTn2vfkv8UJUUUU8Yxn0WfASr-VFAUDa7-sFnT 9fnUUvcSsGvfC2KfnxnUUI43ZEXa7IUbqYLPUUUUU== X-Originating-IP: [116.77.128.176] X-CM-SenderInfo: 5jhoxtpqjwt0rj6rljoofrz/1tbiNRXMmVSIKsEeWgAAsG Sender: linux-block-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-block@vger.kernel.org X-Spam-Status: No, score=-6.8 required=5.0 tests=BAYES_00,DKIM_SIGNED, FREEMAIL_FROM,RCVD_IN_DNSWL_HI,T_DKIM_INVALID,T_RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=ham version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP For better readability, use list_is_{first,last}() instead of open-coded. Signed-off-by: Geliang Tang --- block/noop-iosched.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/block/noop-iosched.c b/block/noop-iosched.c index a163c48..d44326e 100644 --- a/block/noop-iosched.c +++ b/block/noop-iosched.c @@ -44,7 +44,7 @@ noop_former_request(struct request_queue *q, struct request *rq) { struct noop_data *nd = q->elevator->elevator_data; - if (rq->queuelist.prev == &nd->queue) + if (list_is_first(&rq->queuelist, &nd->queue)) return NULL; return list_prev_entry(rq, queuelist); } @@ -54,7 +54,7 @@ noop_latter_request(struct request_queue *q, struct request *rq) { struct noop_data *nd = q->elevator->elevator_data; - if (rq->queuelist.next == &nd->queue) + if (list_is_last(&rq->queuelist, &nd->queue)) return NULL; return list_next_entry(rq, queuelist); }