diff mbox series

[v3,2/7] block: rename __blk_mq_alloc_rq_maps

Message ID 51ece5240eda7e9ab80be0abf784a05fba7eef1a.1586199103.git.zhangweiping@didiglobal.com (mailing list archive)
State New, archived
Headers show
Series Fix potential kernel panic when increase hardware queue | expand

Commit Message

Weiping Zhang April 6, 2020, 7:36 p.m. UTC
rename __blk_mq_alloc_rq_maps to __blk_mq_alloc_rq_map_and_requests,
this function allocs both map and request, make function name align
with funtion.

Signed-off-by: Weiping Zhang <zhangweiping@didiglobal.com>
---
 block/blk-mq.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

Comments

Bart Van Assche April 20, 2020, 8:46 p.m. UTC | #1
On 4/6/20 12:36 PM, Weiping Zhang wrote:
> rename __blk_mq_alloc_rq_maps to __blk_mq_alloc_rq_map_and_requests,
> this function allocs both map and request, make function name align
> with funtion.
> 
> Signed-off-by: Weiping Zhang <zhangweiping@didiglobal.com>
> ---
>   block/blk-mq.c | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/block/blk-mq.c b/block/blk-mq.c
> index 3a482ce7ed28..5a322130aaf2 100644
> --- a/block/blk-mq.c
> +++ b/block/blk-mq.c
> @@ -2978,7 +2978,7 @@ void blk_mq_exit_queue(struct request_queue *q)
>   	blk_mq_exit_hw_queues(q, set, set->nr_hw_queues);
>   }
>   
> -static int __blk_mq_alloc_rq_maps(struct blk_mq_tag_set *set)
> +static int __blk_mq_alloc_rq_map_and_requests(struct blk_mq_tag_set *set)
>   {
>   	int i;
>   
> @@ -3007,7 +3007,7 @@ static int blk_mq_alloc_rq_maps(struct blk_mq_tag_set *set)
>   
>   	depth = set->queue_depth;
>   	do {
> -		err = __blk_mq_alloc_rq_maps(set);
> +		err = __blk_mq_alloc_rq_map_and_requests(set);
>   		if (!err)
>   			break;

Just like for the previous patch, I prefer not to rename 
__blk_mq_alloc_rq_maps().

Thanks,

Bart.
diff mbox series

Patch

diff --git a/block/blk-mq.c b/block/blk-mq.c
index 3a482ce7ed28..5a322130aaf2 100644
--- a/block/blk-mq.c
+++ b/block/blk-mq.c
@@ -2978,7 +2978,7 @@  void blk_mq_exit_queue(struct request_queue *q)
 	blk_mq_exit_hw_queues(q, set, set->nr_hw_queues);
 }
 
-static int __blk_mq_alloc_rq_maps(struct blk_mq_tag_set *set)
+static int __blk_mq_alloc_rq_map_and_requests(struct blk_mq_tag_set *set)
 {
 	int i;
 
@@ -3007,7 +3007,7 @@  static int blk_mq_alloc_rq_maps(struct blk_mq_tag_set *set)
 
 	depth = set->queue_depth;
 	do {
-		err = __blk_mq_alloc_rq_maps(set);
+		err = __blk_mq_alloc_rq_map_and_requests(set);
 		if (!err)
 			break;