diff mbox series

blk-cgroup: delete rcu_read_lock_held() WARN_ON_ONCE()

Message ID 52f2c742-9e64-63b0-25c3-8052f7e85883@kernel.dk (mailing list archive)
State New, archived
Headers show
Series blk-cgroup: delete rcu_read_lock_held() WARN_ON_ONCE() | expand

Commit Message

Jens Axboe May 18, 2022, 10:35 p.m. UTC
A previous commit got rid of unnecessary rcu_read_lock() inside the
IRQ disabling queue_lock, but this debug statement was left. It's now
firing since we are indeed not inside a RCU read lock, but we don't
need to be as we're still preempt safe.

Get rid of the check, as we have a lockdep assert for holding the
queue lock right after it anyway.

Link: https://lore.kernel.org/linux-block/46253c48-81cb-0787-20ad-9133afdd9e21@samsung.com/
Reported-by: Marek Szyprowski <m.szyprowski@samsung.com>
Fixes: 77c570a1ea85 ("blk-cgroup: Remove unnecessary rcu_read_lock/unlock()")
Signed-off-by: Jens Axboe <axboe@kernel.dk>

diff mbox series


diff --git a/block/blk-cgroup.c b/block/blk-cgroup.c
index 0676cf7a41b5..40161a3f68d0 100644
--- a/block/blk-cgroup.c
+++ b/block/blk-cgroup.c
@@ -298,7 +298,6 @@  static struct blkcg_gq *blkg_create(struct blkcg *blkcg,
 	struct blkcg_gq *blkg;
 	int i, ret;
-	WARN_ON_ONCE(!rcu_read_lock_held());
 	/* request_queue is dying, do not create/recreate a blkg */