From patchwork Mon Apr 4 18:05:51 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Jeff Mahoney X-Patchwork-Id: 8743511 Return-Path: X-Original-To: patchwork-linux-block@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork1.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.136]) by patchwork1.web.kernel.org (Postfix) with ESMTP id 553419F39A for ; Mon, 4 Apr 2016 18:06:00 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 70855201FA for ; Mon, 4 Apr 2016 18:05:59 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id D5269201DD for ; Mon, 4 Apr 2016 18:05:53 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754398AbcDDSFx (ORCPT ); Mon, 4 Apr 2016 14:05:53 -0400 Received: from mx2.suse.de ([195.135.220.15]:38913 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751587AbcDDSFw (ORCPT ); Mon, 4 Apr 2016 14:05:52 -0400 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay1.suse.de (charybdis-ext.suse.de [195.135.220.254]) by mx2.suse.de (Postfix) with ESMTP id 1E108ABBF; Mon, 4 Apr 2016 18:05:50 +0000 (UTC) To: linux-block@vger.kernel.org, Matias Bjorling From: Jeff Mahoney Subject: =?UTF-8?Q?[PATCH]_lightnvm:_fix_=22warning:_=e2=80=98ret=e2=80=99_m?= =?UTF-8?Q?ay_be_used_uninitialized=22?= Message-ID: <5702ACFF.90708@suse.com> Date: Mon, 4 Apr 2016 14:05:51 -0400 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.11; rv:38.0) Gecko/20100101 Thunderbird/38.7.0 MIME-Version: 1.0 Sender: linux-block-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-block@vger.kernel.org X-Spam-Status: No, score=-7.9 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_HI, RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=ham version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP This fixes the following warnings: drivers/lightnvm/sysblk.c:125:9: warning: ‘ret’ may be used uninitialized in this function drivers/lightnvm/sysblk.c:275:15: warning: ‘ret’ may be used uninitialized in this function In both cases, ret is only set from within a loop that may not be entered. Signed-off-by: Jeff Mahoney Reviewed-by: Johannes Thumshirn --- drivers/lightnvm/sysblk.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) --- a/drivers/lightnvm/sysblk.c +++ b/drivers/lightnvm/sysblk.c @@ -122,7 +122,7 @@ static int nvm_get_all_sysblks(struct nv struct ppa_addr *ppas, nvm_bb_update_fn *fn) { struct ppa_addr dppa; - int i, ret; + int i, ret = 0; s->nr_ppas = 0; @@ -272,7 +272,7 @@ static int nvm_write_and_verify(struct n { struct nvm_system_block nvmsb; void *buf; - int i, sect, ret, bufsz; + int i, sect, ret = 0, bufsz; struct ppa_addr *ppas; nvm_cpu_to_sysblk(&nvmsb, info);