| Message ID | 57af5f3e-9cfe-b6d8-314c-f59855408cd5@linux.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | MAINTAINERS: floppy: take over maintainership | expand |
On 7/31/19 8:47 AM, Denis Efremov wrote: > Hi All, > > On 18.07.2019 01:03, Jiri Kosina wrote: >> On Wed, 17 Jul 2019, Linus Torvalds wrote: >> >>> I don't think we really have a floppy maintainer any more, >> >> Yeah, I basically volunteered myself to maintain it quite some time >> ago back when I fixed the concurrency issues which exhibited itself >> only with VM-emulated devices, and at the same time I still had the >> physical 3.5" reader. >> >> The hardware doesn't work any more though. So I guess I should just >> remove myself as a maintainer to reflect the reality and mark floppy.c >> as Orphaned. > > Well, without jokes about Thunderdome, I've got time, hardware and > would like to maintain the floppy. Except the for recent fixes, > I described floppy ioctls in syzkaller. I've already spent quite > a lot of time with this code. Thus, if nobody minds Great, can't see anyone objecting to doling out some floppy love. Applied, thanks.
Hi Denis, On Wed, Jul 31, 2019 at 05:47:40PM +0300, Denis Efremov wrote: > Well, without jokes about Thunderdome, I've got time, hardware and > would like to maintain the floppy. Except the for recent fixes, > I described floppy ioctls in syzkaller. I've already spent quite > a lot of time with this code. Thus, if nobody minds There's no reason for jokes around this, I think you stepping up on this one will be much welcome. There are still a lot of floppies in the wild and we'd better make sure they continue to work well. Thanks for doing this. Willy
On Wed, Jul 31, 2019 at 08:53:22AM -0600, Jens Axboe wrote: > On 7/31/19 8:47 AM, Denis Efremov wrote: > > Hi All, > > > > On 18.07.2019 01:03, Jiri Kosina wrote: > >> On Wed, 17 Jul 2019, Linus Torvalds wrote: > >> > >>> I don't think we really have a floppy maintainer any more, > >> > >> Yeah, I basically volunteered myself to maintain it quite some time > >> ago back when I fixed the concurrency issues which exhibited itself > >> only with VM-emulated devices, and at the same time I still had the > >> physical 3.5" reader. > >> > >> The hardware doesn't work any more though. So I guess I should just > >> remove myself as a maintainer to reflect the reality and mark floppy.c > >> as Orphaned. > > > > Well, without jokes about Thunderdome, I've got time, hardware and > > would like to maintain the floppy. Except the for recent fixes, > > I described floppy ioctls in syzkaller. I've already spent quite > > a lot of time with this code. Thus, if nobody minds > > Great, can't see anyone objecting to doling out some floppy love. Whatever that involves, I don't like the sound of it. > Applied, thanks. Here's a belated Ack if you can add it: Acked-by: Will Deacon <will@kernel.org> Either way, thanks Denis. Will
On 7/31/19 9:22 AM, Will Deacon wrote: > On Wed, Jul 31, 2019 at 08:53:22AM -0600, Jens Axboe wrote: >> On 7/31/19 8:47 AM, Denis Efremov wrote: >>> Hi All, >>> >>> On 18.07.2019 01:03, Jiri Kosina wrote: >>>> On Wed, 17 Jul 2019, Linus Torvalds wrote: >>>> >>>>> I don't think we really have a floppy maintainer any more, >>>> >>>> Yeah, I basically volunteered myself to maintain it quite some time >>>> ago back when I fixed the concurrency issues which exhibited itself >>>> only with VM-emulated devices, and at the same time I still had the >>>> physical 3.5" reader. >>>> >>>> The hardware doesn't work any more though. So I guess I should just >>>> remove myself as a maintainer to reflect the reality and mark floppy.c >>>> as Orphaned. >>> >>> Well, without jokes about Thunderdome, I've got time, hardware and >>> would like to maintain the floppy. Except the for recent fixes, >>> I described floppy ioctls in syzkaller. I've already spent quite >>> a lot of time with this code. Thus, if nobody minds >> >> Great, can't see anyone objecting to doling out some floppy love. > > Whatever that involves, I don't like the sound of it. Floppy love? It's not that hard. This is where we need GIFs in kernel communication... > Here's a belated Ack if you can add it: > > Acked-by: Will Deacon <will@kernel.org> Added, thanks.
On Wed, 31 Jul 2019, Denis Efremov wrote: > Well, without jokes about Thunderdome, I've got time, hardware and > would like to maintain the floppy. Except the for recent fixes, > I described floppy ioctls in syzkaller. I've already spent quite > a lot of time with this code. Thus, if nobody minds > > -- >8 -- > From: Denis Efremov <efremov@linux.com> > Subject: [PATCH] MAINTAINERS: floppy: take over maintainership > > I would like to maintain the floppy driver. After the recent fixes, > I think I know the code pretty well. Nowadays I've got 2 physical 3.5" > readers to test all the changes. > > Signed-off-by: Denis Efremov <efremov@linux.com> Awesome, thanks a lot Denis for offering to carry the torch I dropped. Obviously: Acked-by: Jiri Kosina <jkosina@suse.cz>
Hi! On Wed 2019-07-31 17:47:40, Denis Efremov wrote: > Hi All, > > On 18.07.2019 01:03, Jiri Kosina wrote: > > On Wed, 17 Jul 2019, Linus Torvalds wrote: > > > >> I don't think we really have a floppy maintainer any more, > > > > Yeah, I basically volunteered myself to maintain it quite some time > > ago back when I fixed the concurrency issues which exhibited itself > > only with VM-emulated devices, and at the same time I still had the > > physical 3.5" reader. For the record, I still have three or maybe more 3.5" drives here, if you want them, delivery to your office should be easy ;-). > > The hardware doesn't work any more though. So I guess I should just > > remove myself as a maintainer to reflect the reality and mark floppy.c > > as Orphaned. > > Well, without jokes about Thunderdome, I've got time, hardware and > would like to maintain the floppy. Except the for recent fixes, > I described floppy ioctls in syzkaller. I've already spent quite > a lot of time with this code. Thus, if nobody minds Thanks for doing this! Best regards, Pavel
diff --git a/MAINTAINERS b/MAINTAINERS index 6426db5198f0..6c49b48cfd69 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -6322,7 +6322,8 @@ F: Documentation/devicetree/bindings/counter/ftm-quaddec.txt F: drivers/counter/ftm-quaddec.c FLOPPY DRIVER -S: Orphan +M: Denis Efremov <efremov@linux.com> +S: Odd Fixes L: linux-block@vger.kernel.org F: drivers/block/floppy.c