diff mbox series

bfq: Fix bfq linkage error

Message ID 9afc7a2cd013344290096d9dfe9355bcb57b3bbd.1568482098.git.asml.silence@gmail.com (mailing list archive)
State New, archived
Headers show
Series bfq: Fix bfq linkage error | expand

Commit Message

Pavel Begunkov Sept. 14, 2019, 5:31 p.m. UTC 
From: Pavel Begunkov <asml.silence@gmail.com>

Since commit 795fe54c2a828099e ("bfq: Add per-device weight"), bfq uses
blkg_conf_prep() and blkg_conf_finish(), which are not exported. So, it
causes linkage error if bfq compiled as a module.

Signed-off-by: Pavel Begunkov <asml.silence@gmail.com>
---
 block/blk-cgroup.c | 2 ++
 1 file changed, 2 insertions(+)

Comments

Jens Axboe Sept. 14, 2019, 5:32 p.m. UTC | #1 
On 9/14/19 11:31 AM, Pavel Begunkov (Silence) wrote:
> From: Pavel Begunkov <asml.silence@gmail.com>
> 
> Since commit 795fe54c2a828099e ("bfq: Add per-device weight"), bfq uses
> blkg_conf_prep() and blkg_conf_finish(), which are not exported. So, it
> causes linkage error if bfq compiled as a module.

Thanks, I'll apply and add the Fixes tag.
Fam Sept. 16, 2019, 6:22 a.m. UTC | #2 
On Sat, 09/14 11:32, Jens Axboe wrote:
> On 9/14/19 11:31 AM, Pavel Begunkov (Silence) wrote:
> > From: Pavel Begunkov <asml.silence@gmail.com>
> > 
> > Since commit 795fe54c2a828099e ("bfq: Add per-device weight"), bfq uses
> > blkg_conf_prep() and blkg_conf_finish(), which are not exported. So, it
> > causes linkage error if bfq compiled as a module.
> 
> Thanks, I'll apply and add the Fixes tag.

Thanks!  This is indeed my oversight.

Fam
diff mbox series

Patch

diff --git a/block/blk-cgroup.c b/block/blk-cgroup.c
index 0e2619c1a422..b6f20be0fc78 100644
--- a/block/blk-cgroup.c
+++ b/block/blk-cgroup.c
@@ -900,6 +900,7 @@  int blkg_conf_prep(struct blkcg *blkcg, const struct blkcg_policy *pol,
 	}
 	return ret;
 }
+EXPORT_SYMBOL_GPL(blkg_conf_prep);
 
 /**
  * blkg_conf_finish - finish up per-blkg config update
@@ -915,6 +916,7 @@  void blkg_conf_finish(struct blkg_conf_ctx *ctx)
 	rcu_read_unlock();
 	put_disk_and_module(ctx->disk);
 }
+EXPORT_SYMBOL_GPL(blkg_conf_finish);
 
 static int blkcg_print_stat(struct seq_file *sf, void *v)
 {