From patchwork Fri Mar 12 11:08:43 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "brookxu.cn" X-Patchwork-Id: 12134351 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DA8D6C43619 for ; Fri, 12 Mar 2021 11:09:52 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id BD67C6501C for ; Fri, 12 Mar 2021 11:09:52 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234084AbhCLLJX (ORCPT ); Fri, 12 Mar 2021 06:09:23 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43982 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234119AbhCLLJJ (ORCPT ); Fri, 12 Mar 2021 06:09:09 -0500 Received: from mail-pj1-x102b.google.com (mail-pj1-x102b.google.com [IPv6:2607:f8b0:4864:20::102b]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5E21BC061574; Fri, 12 Mar 2021 03:09:09 -0800 (PST) Received: by mail-pj1-x102b.google.com with SMTP id a22-20020a17090aa516b02900c1215e9b33so10590412pjq.5; Fri, 12 Mar 2021 03:09:09 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :in-reply-to:references; bh=SiVV6EtJZFIFkG/CEJdYUnLYJ8IcYQwEYTMUZJ4BL9Q=; b=YC4HWpCJruAgTzfDhVZNQ6U66EvejBlEQQyydGG0jwfqwp9h3Dr3L7Y3WwGt+Hex6X 1Xcts7hqe3FXHQ5RbBV8FvZRFmKl+KXUbSGbNxR8oXPH/I4mU8cymvoEujoTS12WgP88 uCNoDsD3/sCxjRs62AaH/We1Ys/QfFTEWsYgxmzEW3w6M8mS9HRiy4lCLZMH3Jch0/27 1XLqZyIDbyok6EfcrmOhMjs8IkA9a51KFbeksGzEi+8TtCNyVeWMkJ4a0fVBzsZ6EIrC gs7q7HeVTxkD/6x3/YUNQg1mIkOxjx8rqVDk6IY5ry+ruSeK5RW/HS/SSlQ4YZTawn/Z 3OYA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:in-reply-to:references; bh=SiVV6EtJZFIFkG/CEJdYUnLYJ8IcYQwEYTMUZJ4BL9Q=; b=PHmT+zNby/NWifMyTrExJP0lPDvmOxXtKSDaX9hG3IypAciQbIp2v/LrRzjsSFp23s rmwwYh4SodxYFwvxRPRoLho6T14N9O6FJkTbGAx3I9D9SnJcaF2Mm9iAXiGUkOpEYwFY W+KohNtHN8BYDYu0qY+Zf2HQkfF/XKcyRLQ0OAfZ6IlsDQ1OcpfvmyKqHjU5hCE1p4hr iqNLHI/lF6ZotNpN4SGzqpcmYlMdzty3sSEuqh9+3adjYkhUgUgMcPyLJqQBAtXi0VpZ /38ShFXRP557y75uaN7edn7bbCeHj2OU6erlfUJpMBbva+RjE9P9hPKtGn4Uzot3nJPI c4MQ== X-Gm-Message-State: AOAM531G9vIQ409ZuIKS6p8ofiLG7sZllYGIy08AAWvmxKZLtWSxZTGP kpBQJczae9KqxrxPzmkhFS8= X-Google-Smtp-Source: ABdhPJwBs2BSLFhpEfC6/U4aNhlZ0ug3jSui6YDmWiHRb6gjqtsFFYiMX+WabYyEtJTzDFyhZ3TcUw== X-Received: by 2002:a17:902:e8cb:b029:e2:9906:45a6 with SMTP id v11-20020a170902e8cbb02900e2990645a6mr13043416plg.41.1615547349036; Fri, 12 Mar 2021 03:09:09 -0800 (PST) Received: from VM-0-3-centos.localdomain ([101.32.213.191]) by smtp.gmail.com with ESMTPSA id t5sm4942181pgl.89.2021.03.12.03.09.07 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Fri, 12 Mar 2021 03:09:08 -0800 (PST) From: brookxu To: paolo.valente@linaro.org, axboe@kernel.dk, tj@kernel.org Cc: linux-block@vger.kernel.org, cgroups@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [RFC PATCH v2 09/11] bfq: disallow merge CLASS_RT with other class Date: Fri, 12 Mar 2021 19:08:43 +0800 Message-Id: <9b3b89cf193896f459b5c59f58b65783df0f490c.1615527324.git.brookxu@tencent.com> X-Mailer: git-send-email 1.8.3.1 In-Reply-To: References: In-Reply-To: References: Precedence: bulk List-ID: X-Mailing-List: linux-block@vger.kernel.org From: Chunguang Xu In EMQ, perhaps we should not merge the CLASS_RT queue with other class queues. Otherwise, the delay of CLASS_RT IO will increase. Signed-off-by: Chunguang Xu --- block/bfq-iosched.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/block/bfq-iosched.c b/block/bfq-iosched.c index 9330043cdd53..bb6cc8c9ddf5 100644 --- a/block/bfq-iosched.c +++ b/block/bfq-iosched.c @@ -2623,6 +2623,9 @@ static bool bfq_may_be_close_cooperator(struct bfq_queue *bfqq, if (!bfq_bfqq_sync(bfqq) || !bfq_bfqq_sync(new_bfqq)) return false; + if (bfq_class_rt(bfqq) && !bfq_class_rt(new_bfqq)) + return false; + return true; }