mbox series

[GIT,PULL] second round of nvme updates for Linux 5.16

Message ID YXqzb6dj0DCrIbGY@infradead.org (mailing list archive)
State New, archived
Headers show
Series [GIT,PULL] second round of nvme updates for Linux 5.16 | expand

Pull-request

git://git.infradead.org/nvme.git tags/nvme-5.16-2021-10-28

Message

Christoph Hellwig Oct. 28, 2021, 2:27 p.m. UTC 
The following changes since commit d28e4dff085c5a87025c9a0a85fb798bd8e9ca17:

  block: ataflop: more blk-mq refactoring fixes (2021-10-25 07:54:32 -0600)

are available in the Git repository at:

  git://git.infradead.org/nvme.git tags/nvme-5.16-2021-10-28

for you to fetch changes up to d156cfcafbd0eae4224ea007d95ebda467eb0c46:

  nvmet: use flex_array_size and struct_size (2021-10-27 08:06:41 +0200)

----------------------------------------------------------------
nvme updates for Linux 5.16

 - support the current discovery subsystem entry (Hannes Reinecke)
 - use flex_array_size and struct_size (Len Baker)

----------------------------------------------------------------
Hannes Reinecke (3):
      nvme: add new discovery log page entry definitions
      nvmet: switch check for subsystem type
      nvmet: register discovery subsystem as 'current'

Len Baker (1):
      nvmet: use flex_array_size and struct_size

 drivers/nvme/host/multipath.c   |  2 +-
 drivers/nvme/target/admin-cmd.c |  2 +-
 drivers/nvme/target/core.c      |  1 +
 drivers/nvme/target/discovery.c | 17 +++++++++++------
 drivers/nvme/target/nvmet.h     |  2 +-
 include/linux/nvme.h            | 19 ++++++++++++++++---
 6 files changed, 31 insertions(+), 12 deletions(-)

Comments

Jens Axboe Oct. 28, 2021, 2:35 p.m. UTC | #1 
On 10/28/21 8:27 AM, Christoph Hellwig wrote:
> The following changes since commit d28e4dff085c5a87025c9a0a85fb798bd8e9ca17:
> 
>   block: ataflop: more blk-mq refactoring fixes (2021-10-25 07:54:32 -0600)
> 
> are available in the Git repository at:
> 
>   git://git.infradead.org/nvme.git tags/nvme-5.16-2021-10-28

Pulled, thanks.
Hannes Reinecke Oct. 29, 2021, 10:19 a.m. UTC | #2 
On 10/28/21 4:27 PM, Christoph Hellwig wrote:
> The following changes since commit d28e4dff085c5a87025c9a0a85fb798bd8e9ca17:
> 
>   block: ataflop: more blk-mq refactoring fixes (2021-10-25 07:54:32 -0600)
> 
> are available in the Git repository at:
> 
>   git://git.infradead.org/nvme.git tags/nvme-5.16-2021-10-28
> 
> for you to fetch changes up to d156cfcafbd0eae4224ea007d95ebda467eb0c46:
> 
>   nvmet: use flex_array_size and struct_size (2021-10-27 08:06:41 +0200)
> 
> ----------------------------------------------------------------
> nvme updates for Linux 5.16
> 
>  - support the current discovery subsystem entry (Hannes Reinecke)
>  - use flex_array_size and struct_size (Len Baker)
> 
> ----------------------------------------------------------------
> Hannes Reinecke (3):
>       nvme: add new discovery log page entry definitions
>       nvmet: switch check for subsystem type
>       nvmet: register discovery subsystem as 'current'
> 
> Len Baker (1):
>       nvmet: use flex_array_size and struct_size
> 
>  drivers/nvme/host/multipath.c   |  2 +-
>  drivers/nvme/target/admin-cmd.c |  2 +-
>  drivers/nvme/target/core.c      |  1 +
>  drivers/nvme/target/discovery.c | 17 +++++++++++------
>  drivers/nvme/target/nvmet.h     |  2 +-
>  include/linux/nvme.h            | 19 ++++++++++++++++---
>  6 files changed, 31 insertions(+), 12 deletions(-)
> 
This one hangs at boot for me:

[  220.294358] Code: ef e8 61 25 3e 00 3b 05 3f c1 5d 01 89 c5 73 24 48
63 c5 49 8b 7d 00 48 03 3c c5 c0 0a 20 82 66 90 8b 47 08 a8 01 74 0a f3
90 <8b> 57 08 83 e2 01 75 f6 eb c7 48 83 c4 48 5b 5d 41 5c 41 5d 41 5e
[  220.297931] RSP: 0018:ffffc900011ebd20 EFLAGS: 00000202
[  220.299181] RAX: 0000000000000011 RBX: 0000000000000001 RCX:
0000000000000000
[  220.300656] RDX: 0000000000000001 RSI: 0000000000000000 RDI:
ffff88827fc32d40
[  220.302126] RBP: 0000000000000000 R08: 0000000000000000 R09:
0000000000000000
[  220.303603] R10: 0000000000000000 R11: 0000000000000000 R12:
ffff88827fdec040
[  220.305052] R13: ffff88827fdec040 R14: 0000000000000000 R15:
0000000000000006
[  220.306509] FS:  0000000000000000(0000) GS:ffff88827fdc0000(0000)
knlGS:0000000000000000
[  220.308074] CS:  0010 DS: 0000 ES: 0000 CR0: 0000000080050033
[  220.309338] CR2: 00005644f553dcd8 CR3: 000000010392e000 CR4:
0000000000350ee0
[  220.310777] Call Trace:
[  220.311655]  ? __flush_tlb_all+0x30/0x30
[  220.312686]  on_each_cpu_cond_mask+0x1e/0x20
[  220.313776]  __purge_vmap_area_lazy+0xbc/0x6d0
[  220.314887]  ? __cond_resched+0x15/0x40
[  220.315921]  ? vunmap_range_noflush+0x3fc/0x4b0
[  220.317024]  ? cpumask_next+0x1f/0x30
[  220.318002]  ? purge_fragmented_blocks_allcpus+0x51/0x1d0
[  220.319235]  _vm_unmap_aliases.part.50+0xdf/0x110
[  220.320356]  __vunmap+0x11d/0x250
[  220.321301]  do_free_init+0x26/0x50
[  220.322266]  process_one_work+0x231/0x420
[  220.323304]  ? process_one_work+0x420/0x420
[  220.324352]  worker_thread+0x2d/0x3f0
[  220.325346]  ? process_one_work+0x420/0x420
[  220.326400]  kthread+0x11a/0x140
[  220.327362]  ? set_kthread_struct+0x40/0x40
[  220.328413]  ret_from_fork+0x22/0x30

Known issue?

Cheers,

Hannes
Hannes Reinecke Oct. 29, 2021, 10:32 a.m. UTC | #3 
On 10/29/21 12:19 PM, Hannes Reinecke wrote:
> On 10/28/21 4:27 PM, Christoph Hellwig wrote:
>> The following changes since commit d28e4dff085c5a87025c9a0a85fb798bd8e9ca17:
>>
>>   block: ataflop: more blk-mq refactoring fixes (2021-10-25 07:54:32 -0600)
>>
>> are available in the Git repository at:
>>
>>   git://git.infradead.org/nvme.git tags/nvme-5.16-2021-10-28
>>
>> for you to fetch changes up to d156cfcafbd0eae4224ea007d95ebda467eb0c46:
>>
>>   nvmet: use flex_array_size and struct_size (2021-10-27 08:06:41 +0200)
>>
>> ----------------------------------------------------------------
>> nvme updates for Linux 5.16
>>
>>  - support the current discovery subsystem entry (Hannes Reinecke)
>>  - use flex_array_size and struct_size (Len Baker)
>>
>> ----------------------------------------------------------------
>> Hannes Reinecke (3):
>>       nvme: add new discovery log page entry definitions
>>       nvmet: switch check for subsystem type
>>       nvmet: register discovery subsystem as 'current'
>>
>> Len Baker (1):
>>       nvmet: use flex_array_size and struct_size
>>
>>  drivers/nvme/host/multipath.c   |  2 +-
>>  drivers/nvme/target/admin-cmd.c |  2 +-
>>  drivers/nvme/target/core.c      |  1 +
>>  drivers/nvme/target/discovery.c | 17 +++++++++++------
>>  drivers/nvme/target/nvmet.h     |  2 +-
>>  include/linux/nvme.h            | 19 ++++++++++++++++---
>>  6 files changed, 31 insertions(+), 12 deletions(-)
>>
> This one hangs at boot for me:
> 
> [  220.294358] Code: ef e8 61 25 3e 00 3b 05 3f c1 5d 01 89 c5 73 24 48
> 63 c5 49 8b 7d 00 48 03 3c c5 c0 0a 20 82 66 90 8b 47 08 a8 01 74 0a f3
> 90 <8b> 57 08 83 e2 01 75 f6 eb c7 48 83 c4 48 5b 5d 41 5c 41 5d 41 5e
> [  220.297931] RSP: 0018:ffffc900011ebd20 EFLAGS: 00000202
> [  220.299181] RAX: 0000000000000011 RBX: 0000000000000001 RCX:
> 0000000000000000
> [  220.300656] RDX: 0000000000000001 RSI: 0000000000000000 RDI:
> ffff88827fc32d40
> [  220.302126] RBP: 0000000000000000 R08: 0000000000000000 R09:
> 0000000000000000
> [  220.303603] R10: 0000000000000000 R11: 0000000000000000 R12:
> ffff88827fdec040
> [  220.305052] R13: ffff88827fdec040 R14: 0000000000000000 R15:
> 0000000000000006
> [  220.306509] FS:  0000000000000000(0000) GS:ffff88827fdc0000(0000)
> knlGS:0000000000000000
> [  220.308074] CS:  0010 DS: 0000 ES: 0000 CR0: 0000000080050033
> [  220.309338] CR2: 00005644f553dcd8 CR3: 000000010392e000 CR4:
> 0000000000350ee0
> [  220.310777] Call Trace:
> [  220.311655]  ? __flush_tlb_all+0x30/0x30
> [  220.312686]  on_each_cpu_cond_mask+0x1e/0x20
> [  220.313776]  __purge_vmap_area_lazy+0xbc/0x6d0
> [  220.314887]  ? __cond_resched+0x15/0x40
> [  220.315921]  ? vunmap_range_noflush+0x3fc/0x4b0
> [  220.317024]  ? cpumask_next+0x1f/0x30
> [  220.318002]  ? purge_fragmented_blocks_allcpus+0x51/0x1d0
> [  220.319235]  _vm_unmap_aliases.part.50+0xdf/0x110
> [  220.320356]  __vunmap+0x11d/0x250
> [  220.321301]  do_free_init+0x26/0x50
> [  220.322266]  process_one_work+0x231/0x420
> [  220.323304]  ? process_one_work+0x420/0x420
> [  220.324352]  worker_thread+0x2d/0x3f0
> [  220.325346]  ? process_one_work+0x420/0x420
> [  220.326400]  kthread+0x11a/0x140
> [  220.327362]  ? set_kthread_struct+0x40/0x40
> [  220.328413]  ret_from_fork+0x22/0x30
> 
> Known issue?
> 
Using
kernel/git/axboe/linux-block.git for-next
works.

Just so that you know :-)

Cheers,

Hannes