diff mbox series

[3/4] elevator: repalce "len+name" with "name+len" in elv_iosched_show

Message ID d96b45ef44f240db39d985661ba306eb7bde77d0.1669391142.git.nickyc975@zju.edu.cn (mailing list archive)
State New, archived
Headers show
Series random improvements and cleanups for elevator.c | expand

Commit Message

Jinlong Chen Nov. 25, 2022, 3:53 p.m. UTC 
The "pointer + offset" pattern is more resonable.

Signed-off-by: Jinlong Chen <nickyc975@zju.edu.cn>
---
 block/elevator.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Christoph Hellwig Nov. 29, 2022, 8:33 a.m. UTC | #1 
On Fri, Nov 25, 2022 at 11:53:13PM +0800, Jinlong Chen wrote:
> The "pointer + offset" pattern is more resonable.

Looks good:

Reviewed-by: Christoph Hellwig <hch@lst.de>
diff mbox series

Patch

diff --git a/block/elevator.c b/block/elevator.c
index ffa750976d25..93dbaa560b67 100644
--- a/block/elevator.c
+++ b/block/elevator.c
@@ -783,7 +783,7 @@  ssize_t elv_iosched_show(struct request_queue *q, char *name)
 	}
 	spin_unlock(&elv_list_lock);
 
-	len += sprintf(len+name, "\n");
+	len += sprintf(name+len, "\n");
 	return len;
 }