diff mbox

lightnvm: fix error return code of memdup_user

Message ID f0f70c9326edab0cc56731f24244e86f8ba84ef4.1493727412.git.geliangtang@gmail.com (mailing list archive)
State New, archived
Headers show

Commit Message

Geliang Tang May 6, 2017, 3:34 p.m. UTC 
The error return code of memdup_user() should be -ENOMEM or -EFAULT.
So this patch changed it to PTR_ERR(info).

Signed-off-by: Geliang Tang <geliangtang@gmail.com>
---
 drivers/lightnvm/core.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Matias Bjørling May 8, 2017, 6:56 a.m. UTC | #1 
On 05/06/2017 05:34 PM, Geliang Tang wrote:
> The error return code of memdup_user() should be -ENOMEM or -EFAULT.
> So this patch changed it to PTR_ERR(info).
>
> Signed-off-by: Geliang Tang <geliangtang@gmail.com>
> ---
>  drivers/lightnvm/core.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/lightnvm/core.c b/drivers/lightnvm/core.c
> index 54a06c3..e8b5edd 100644
> --- a/drivers/lightnvm/core.c
> +++ b/drivers/lightnvm/core.c
> @@ -1164,7 +1164,7 @@ static long nvm_ioctl_info(struct file *file, void __user *arg)
>
>  	info = memdup_user(arg, sizeof(struct nvm_ioctl_info));
>  	if (IS_ERR(info))
> -		return -EFAULT;
> +		return PTR_ERR(info);
>
>  	info->version[0] = NVM_VERSION_MAJOR;
>  	info->version[1] = NVM_VERSION_MINOR;
>

Thanks Geliang. Jens, would you pick this beauty up? :)

Reviewed-by: Matias Bjørling <matias@cnexlabs.com>
diff mbox

Patch

diff --git a/drivers/lightnvm/core.c b/drivers/lightnvm/core.c
index 54a06c3..e8b5edd 100644
--- a/drivers/lightnvm/core.c
+++ b/drivers/lightnvm/core.c
@@ -1164,7 +1164,7 @@  static long nvm_ioctl_info(struct file *file, void __user *arg)
 
 	info = memdup_user(arg, sizeof(struct nvm_ioctl_info));
 	if (IS_ERR(info))
-		return -EFAULT;
+		return PTR_ERR(info);
 
 	info->version[0] = NVM_VERSION_MAJOR;
 	info->version[1] = NVM_VERSION_MINOR;