| Message ID | f70bb480aef6f55228a25ce20ff0e88e670e1b70.1709667858.git.daniel@makrotopia.org (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | nvmem: add block device NVMEM provider | expand |
Hi Daniel, On Tue, Mar 05, 2024 at 08:23:20PM +0000, Daniel Golle wrote: > diff --git a/Documentation/devicetree/bindings/block/partition.yaml b/Documentation/devicetree/bindings/block/partition.yaml > new file mode 100644 > index 0000000000000..df561dd33cbc9 > --- /dev/null > +++ b/Documentation/devicetree/bindings/block/partition.yaml > @@ -0,0 +1,51 @@ > +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/block/partition.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Partition on a block device > + > +description: | > + This binding describes a partition on a block storage device. > + Partitions may be matched by a combination of partition number, name, > + and UUID. > + > +maintainers: > + - Daniel Golle <daniel@makrotopia.org> > + > +properties: > + $nodename: > + pattern: '^block-partition-.+$' > + > + partnum: > + $ref: /schemas/types.yaml#/definitions/uint32 > + description: > + Matches partition by number if present. > + > + partname: > + $ref: /schemas/types.yaml#/definitions/string > + description: > + Matches partition by PARTNAME if present. In the mtd world we originally had the partition nodes directly under the hardware device node as well. That was changed to put a partitions subnode between the hardware device node and the partitions. From fe2585e9c29a ("doc: dt: mtd: support partitions in a special 'partitions' subnode"): To avoid conflict with other drivers using subnodes of the mtd device create only one ofpart-specific node rather than any number of arbitrary partition subnodes. Does it make sense to do the same for block devices? Sascha
On Wed, Mar 06, 2024 at 08:22:59AM +0100, Sascha Hauer wrote: > Hi Daniel, > > On Tue, Mar 05, 2024 at 08:23:20PM +0000, Daniel Golle wrote: > > diff --git a/Documentation/devicetree/bindings/block/partition.yaml b/Documentation/devicetree/bindings/block/partition.yaml > > new file mode 100644 > > index 0000000000000..df561dd33cbc9 > > --- /dev/null > > +++ b/Documentation/devicetree/bindings/block/partition.yaml > > @@ -0,0 +1,51 @@ > > +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause > > +%YAML 1.2 > > +--- > > +$id: http://devicetree.org/schemas/block/partition.yaml# > > +$schema: http://devicetree.org/meta-schemas/core.yaml# > > + > > +title: Partition on a block device > > + > > +description: | > > + This binding describes a partition on a block storage device. > > + Partitions may be matched by a combination of partition number, name, > > + and UUID. > > + > > +maintainers: > > + - Daniel Golle <daniel@makrotopia.org> > > + > > +properties: > > + $nodename: > > + pattern: '^block-partition-.+$' > > + > > + partnum: > > + $ref: /schemas/types.yaml#/definitions/uint32 > > + description: > > + Matches partition by number if present. > > + > > + partname: > > + $ref: /schemas/types.yaml#/definitions/string > > + description: > > + Matches partition by PARTNAME if present. > > In the mtd world we originally had the partition nodes directly under > the hardware device node as well. That was changed to put a > partitions subnode between the hardware device node and the partitions. > > From fe2585e9c29a ("doc: dt: mtd: support partitions in a special > 'partitions' subnode"): > > To avoid conflict with other drivers using subnodes of the mtd device > create only one ofpart-specific node rather than any number of > arbitrary partition subnodes. > > Does it make sense to do the same for block devices? Hm, looking at the example in 5/8 it seems you've already done that. I think I have misread the binding. Sascha
On Tue, Mar 05, 2024 at 08:23:20PM +0000, Daniel Golle wrote: > Add bindings for block devices which are used to allow referencing > nvmem bits on them. > > Signed-off-by: Daniel Golle <daniel@makrotopia.org> > --- > .../bindings/block/block-device.yaml | 22 ++++++++ > .../devicetree/bindings/block/partition.yaml | 51 +++++++++++++++++++ > .../devicetree/bindings/block/partitions.yaml | 20 ++++++++ > 3 files changed, 93 insertions(+) > create mode 100644 Documentation/devicetree/bindings/block/block-device.yaml > create mode 100644 Documentation/devicetree/bindings/block/partition.yaml > create mode 100644 Documentation/devicetree/bindings/block/partitions.yaml > > diff --git a/Documentation/devicetree/bindings/block/block-device.yaml b/Documentation/devicetree/bindings/block/block-device.yaml > new file mode 100644 > index 0000000000000..c83ea525650ba > --- /dev/null > +++ b/Documentation/devicetree/bindings/block/block-device.yaml > @@ -0,0 +1,22 @@ > +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/block/block-device.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: block storage device > + > +description: | > + This binding is generic and describes a block-oriented storage device. > + > +maintainers: > + - Daniel Golle <daniel@makrotopia.org> > + > +properties: > + partitions: > + $ref: /schemas/block/partitions.yaml > + > + nvmem-layout: > + $ref: /schemas/nvmem/layouts/nvmem-layout.yaml# > + > +unevaluatedProperties: false > diff --git a/Documentation/devicetree/bindings/block/partition.yaml b/Documentation/devicetree/bindings/block/partition.yaml > new file mode 100644 > index 0000000000000..df561dd33cbc9 > --- /dev/null > +++ b/Documentation/devicetree/bindings/block/partition.yaml > @@ -0,0 +1,51 @@ > +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/block/partition.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Partition on a block device > + > +description: | > + This binding describes a partition on a block storage device. > + Partitions may be matched by a combination of partition number, name, > + and UUID. > + > +maintainers: > + - Daniel Golle <daniel@makrotopia.org> > + > +properties: > + $nodename: > + pattern: '^block-partition-.+$' > + > + partnum: > + $ref: /schemas/types.yaml#/definitions/uint32 > + description: > + Matches partition by number if present. > + > + partname: > + $ref: /schemas/types.yaml#/definitions/string > + description: > + Matches partition by PARTNAME if present. Why do we need something new here? The existing fixed-partitions can already define block device partitions. It just matches by address/offset which works whether its MBR or GPT. Also, in DT we always have an address when there is an address. I'm sure you want to statically define this and have it work even if the partitions move, but sorry... > + > + uuid: > + $ref: /schemas/types.yaml#/definitions/string > + description: > + Matches partition by PARTUUID if present. If this remains it will need some work in the dtschema tools. The reason is json-schema already has support for UUIDs as a defined 'format' key value and we should use that. > + > + nvmem-layout: > + $ref: /schemas/nvmem/layouts/nvmem-layout.yaml# > + description: > + This container may reference an NVMEM layout parser. > + > +anyOf: > + - required: > + - partnum > + > + - required: > + - partname > + > + - required: > + - uuid > + > +unevaluatedProperties: false
> -----Original Message----- > From: Rob Herring <robh@kernel.org> > Sent: Thursday, March 7, 2024 6:51 AM > To: Daniel Golle <daniel@makrotopia.org> > Cc: Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>; Conor Dooley > <conor+dt@kernel.org>; Ulf Hansson <ulf.hansson@linaro.org>; Jens Axboe > <axboe@kernel.dk>; Dave Chinner <dchinner@redhat.com>; Jan Kara > <jack@suse.cz>; Thomas Weißschuh <linux@weissschuh.net>; Christian Brauner > <brauner@kernel.org>; Li Lingfeng <lilingfeng3@huawei.com>; Damien Le Moal > <dlemoal@kernel.org>; Min Li <min15.li@samsung.com>; Adrian Hunter > <adrian.hunter@intel.com>; Hannes Reinecke <hare@suse.de>; Christian Loehle > <CLoehle@hyperstone.com>; Avri Altman <avri.altman@wdc.com>; Bean Huo > <beanhuo@micron.com>; Yeqi Fu <asuk4.q@gmail.com>; Victor Shih > <victor.shih@genesyslogic.com.tw>; Christophe JAILLET > <christophe.jaillet@wanadoo.fr>; Ricardo B. Marliere <ricardo@marliere.net>; > Greg Kroah-Hartman <gregkh@linuxfoundation.org>; devicetree@vger.kernel.org; > linux-kernel@vger.kernel.org; linux-mmc@vger.kernel.org; linux- > block@vger.kernel.org; Diping Zhang <diping.zhang@gl-inet.com>; Jianhui Zhao > <zhaojh329@gmail.com>; Jieying Zeng <jieying.zeng@gl-inet.com>; Chad Monroe > <chad.monroe@adtran.com>; Adam Fox <adam.fox@adtran.com>; John Crispin > <john@phrozen.org> > Subject: [EXTERNAL] Re: [RFC PATCH v2 1/8] dt-bindings: block: add basic bindings > for block devices > > On Tue, Mar 05, 2024 at 08:23:20PM +0000, Daniel Golle wrote: > > Add bindings for block devices which are used to allow referencing > > nvmem bits on them. > > > > Signed-off-by: Daniel Golle <daniel@makrotopia.org> > > --- > > .../bindings/block/block-device.yaml | 22 ++++++++ > > .../devicetree/bindings/block/partition.yaml | 51 +++++++++++++++++++ > > .../devicetree/bindings/block/partitions.yaml | 20 ++++++++ > > 3 files changed, 93 insertions(+) > > create mode 100644 Documentation/devicetree/bindings/block/block- > device.yaml > > create mode 100644 Documentation/devicetree/bindings/block/partition.yaml > > create mode 100644 Documentation/devicetree/bindings/block/partitions.yaml > > > > diff --git a/Documentation/devicetree/bindings/block/block-device.yaml > b/Documentation/devicetree/bindings/block/block-device.yaml > > new file mode 100644 > > index 0000000000000..c83ea525650ba > > --- /dev/null > > +++ b/Documentation/devicetree/bindings/block/block-device.yaml > > @@ -0,0 +1,22 @@ > > +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause > > +%YAML 1.2 > > +--- > > +$id: http://devicetree.org/schemas/block/block-device.yaml# <https://protect- > de.mimecast.com/s/gI6FCDqGk9uBM0gMFZVG39?domain=devicetree.org> > > +$schema: http://devicetree.org/meta-schemas/core.yaml# <https://protect- > de.mimecast.com/s/rGEGCEqJR9uWnMRnHZK6FQ?domain=devicetree.org> > > + > > +title: block storage device > > + > > +description: | > > + This binding is generic and describes a block-oriented storage device. > > + > > +maintainers: > > + - Daniel Golle <daniel@makrotopia.org> > > + > > +properties: > > + partitions: > > + $ref: /schemas/block/partitions.yaml > > + > > + nvmem-layout: > > + $ref: /schemas/nvmem/layouts/nvmem-layout.yaml# > > + > > +unevaluatedProperties: false > > diff --git a/Documentation/devicetree/bindings/block/partition.yaml > b/Documentation/devicetree/bindings/block/partition.yaml > > new file mode 100644 > > index 0000000000000..df561dd33cbc9 > > --- /dev/null > > +++ b/Documentation/devicetree/bindings/block/partition.yaml > > @@ -0,0 +1,51 @@ > > +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause > > +%YAML 1.2 > > +--- > > +$id: http://devicetree.org/schemas/block/partition.yaml# <https://protect- > de.mimecast.com/s/8Tf9CGRL65UJqGjqu07YGR?domain=devicetree.org> > > +$schema: http://devicetree.org/meta-schemas/core.yaml# <https://protect- > de.mimecast.com/s/rGEGCEqJR9uWnMRnHZK6FQ?domain=devicetree.org> > > + > > +title: Partition on a block device > > + > > +description: | > > + This binding describes a partition on a block storage device. > > + Partitions may be matched by a combination of partition number, name, > > + and UUID. > > + > > +maintainers: > > + - Daniel Golle <daniel@makrotopia.org> > > + > > +properties: > > + $nodename: > > + pattern: '^block-partition-.+$' > > + > > + partnum: > > + $ref: /schemas/types.yaml#/definitions/uint32 > > + description: > > + Matches partition by number if present. > > + > > + partname: > > + $ref: /schemas/types.yaml#/definitions/string > > + description: > > + Matches partition by PARTNAME if present. > > Why do we need something new here? The existing fixed-partitions can > already define block device partitions. It just matches by > address/offset which works whether its MBR or GPT. Also, in DT we always > have an address when there is an address. > > I'm sure you want to statically define this and have it work even if the > partitions move, but sorry... The partitions which hold this data are typically defined as a MBR or GPT partition and referenced by PARTNAME, PARTUUID or PARTNO. The data is referenced as an offset within that partition. It's possible for the offset of the RF/calibration partition to change if the size of eMMC chip changes between builds of the same device for example. Within the RF partition the data is always available at the same offsets. Based on this, we don't always know the offset of the RF partition and simply want to use the partition table to point us at the right location. > > > + > > + uuid: > > + $ref: /schemas/types.yaml#/definitions/string > > + description: > > + Matches partition by PARTUUID if present. > > If this remains it will need some work in the dtschema tools. The reason > is json-schema already has support for UUIDs as a defined 'format' key > value and we should use that. > > > + > > + nvmem-layout: > > + $ref: /schemas/nvmem/layouts/nvmem-layout.yaml# > > + description: > > + This container may reference an NVMEM layout parser. > > + > > +anyOf: > > + - required: > > + - partnum > > + > > + - required: > > + - partname > > + > > + - required: > > + - uuid > > + > > +unevaluatedProperties: false
diff --git a/Documentation/devicetree/bindings/block/block-device.yaml b/Documentation/devicetree/bindings/block/block-device.yaml new file mode 100644 index 0000000000000..c83ea525650ba --- /dev/null +++ b/Documentation/devicetree/bindings/block/block-device.yaml @@ -0,0 +1,22 @@ +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/block/block-device.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: block storage device + +description: | + This binding is generic and describes a block-oriented storage device. + +maintainers: + - Daniel Golle <daniel@makrotopia.org> + +properties: + partitions: + $ref: /schemas/block/partitions.yaml + + nvmem-layout: + $ref: /schemas/nvmem/layouts/nvmem-layout.yaml# + +unevaluatedProperties: false diff --git a/Documentation/devicetree/bindings/block/partition.yaml b/Documentation/devicetree/bindings/block/partition.yaml new file mode 100644 index 0000000000000..df561dd33cbc9 --- /dev/null +++ b/Documentation/devicetree/bindings/block/partition.yaml @@ -0,0 +1,51 @@ +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/block/partition.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: Partition on a block device + +description: | + This binding describes a partition on a block storage device. + Partitions may be matched by a combination of partition number, name, + and UUID. + +maintainers: + - Daniel Golle <daniel@makrotopia.org> + +properties: + $nodename: + pattern: '^block-partition-.+$' + + partnum: + $ref: /schemas/types.yaml#/definitions/uint32 + description: + Matches partition by number if present. + + partname: + $ref: /schemas/types.yaml#/definitions/string + description: + Matches partition by PARTNAME if present. + + uuid: + $ref: /schemas/types.yaml#/definitions/string + description: + Matches partition by PARTUUID if present. + + nvmem-layout: + $ref: /schemas/nvmem/layouts/nvmem-layout.yaml# + description: + This container may reference an NVMEM layout parser. + +anyOf: + - required: + - partnum + + - required: + - partname + + - required: + - uuid + +unevaluatedProperties: false diff --git a/Documentation/devicetree/bindings/block/partitions.yaml b/Documentation/devicetree/bindings/block/partitions.yaml new file mode 100644 index 0000000000000..fd84c3ba8493b --- /dev/null +++ b/Documentation/devicetree/bindings/block/partitions.yaml @@ -0,0 +1,20 @@ +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/block/partitions.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: Partitions on block devices + +description: | + This binding is generic and describes the content of the partitions container + node. + +maintainers: + - Daniel Golle <daniel@makrotopia.org> + +patternProperties: + "^block-partition-.+$": + $ref: partition.yaml + +unevaluatedProperties: false
Add bindings for block devices which are used to allow referencing nvmem bits on them. Signed-off-by: Daniel Golle <daniel@makrotopia.org> --- .../bindings/block/block-device.yaml | 22 ++++++++ .../devicetree/bindings/block/partition.yaml | 51 +++++++++++++++++++ .../devicetree/bindings/block/partitions.yaml | 20 ++++++++ 3 files changed, 93 insertions(+) create mode 100644 Documentation/devicetree/bindings/block/block-device.yaml create mode 100644 Documentation/devicetree/bindings/block/partition.yaml create mode 100644 Documentation/devicetree/bindings/block/partitions.yaml